Make the parser recognize 'process crash' and mark test results correctly.

Make the parser recognize 'process crash' and mark test results correctly.

Before the parser only recognize native crash, but not process crash. In
this cl, process crash will be marked as 'CRASHED' instead of 'UNKNOWN'.

BUG=

Committed: https://crrev.com/419b412379e5db6d32858f31f22d1b1ebc6ab2da
Cr-Commit-Position: refs/heads/master@{#409934}

[BigBossZhiling, 2016-08-04 00:57:55]

hzl@google.com changed reviewers:
+ jbudorick@chromium.org

[mikecase (-- gone --), 2016-08-04 01:03:37]

mikecase@chromium.org changed reviewers:
+ mikecase@chromium.org

[mikecase (-- gone --), 2016-08-04 01:03:38]

What is the difference between a "process crash" and "native crash". Just
curious. Do you know?

[jbudorick, 2016-08-04 01:06:39]

On 2016/08/04 01:03:38, mikecase wrote:
> What is the difference between a "process crash" and "native crash". Just
> curious. Do you know?

will show you offline

[jbudorick, 2016-08-04 01:06:48]

lgtm though

[chromium-reviews, 2016-08-04 01:08:09]

I am curious too. What is the difference between process crash and native
crash?

On Wed, Aug 3, 2016 at 6:06 PM, <jbudorick@chromium.org> wrote:

> lgtm though
>
> https://codereview.chromium.org/2207303002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jbudorick, 2016-08-04 01:23:53]

https://codereview.chromium.org/2207303002/diff/1/build/android/pylib/instrum...
File build/android/pylib/instrumentation/instrumentation_test_instance.py
(right):

https://codereview.chromium.org/2207303002/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance.py:51:
_CRASH_RE = re.compile('(process|native) crash', re.IGNORECASE)
er, nit: this should still be _NATIVE_CRASH_RE, as it's still looking for a
native crash

[BigBossZhiling, 2016-08-04 22:30:11]

The CQ bit was checked by hzl@google.com

[BigBossZhiling, 2016-08-04 22:30:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2207303002/#ps20001
(title: "fix variable name")

[BigBossZhiling, 2016-08-04 22:30:34]

https://codereview.chromium.org/2207303002/diff/1/build/android/pylib/instrum...
File build/android/pylib/instrumentation/instrumentation_test_instance.py
(right):

https://codereview.chromium.org/2207303002/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance.py:51:
_CRASH_RE = re.compile('(process|native) crash', re.IGNORECASE)
On 2016/08/04 01:23:53, jbudorick wrote:
> er, nit: this should still be _NATIVE_CRASH_RE, as it's still looking for a
> native crash

Done.

[commit-bot: I haz the power, 2016-08-04 22:30:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 23:34:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-04 23:35:46]

Description was changed from

==========
Make the parser recognize 'process crash' and mark test results correctly.

Before the parser only recognize native crash, but not process crash. In
this cl, process crash will be marked as 'CRASHED' instead of 'UNKNOWN'.

BUG=
==========

to

==========
Make the parser recognize 'process crash' and mark test results correctly.

Before the parser only recognize native crash, but not process crash. In
this cl, process crash will be marked as 'CRASHED' instead of 'UNKNOWN'.

BUG=

Committed: https://crrev.com/419b412379e5db6d32858f31f22d1b1ebc6ab2da
Cr-Commit-Position: refs/heads/master@{#409934}
==========

[commit-bot: I haz the power, 2016-08-04 23:35:47]

Patchset 2 (id:??) landed as
https://crrev.com/419b412379e5db6d32858f31f22d1b1ebc6ab2da
Cr-Commit-Position: refs/heads/master@{#409934}