Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: scripts/slave/recipe_modules/goma/example.py

Issue 2207273003: Implement upload_logs() in recipe_modules/goma (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: change for coverage Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/goma/example.py
diff --git a/scripts/slave/recipe_modules/goma/example.py b/scripts/slave/recipe_modules/goma/example.py
index 14db8055bbcf61f3d301662a5f0562d661e46866..09eed4db491426fbbbe08c3cd20c32345eb5559a 100644
--- a/scripts/slave/recipe_modules/goma/example.py
+++ b/scripts/slave/recipe_modules/goma/example.py
@@ -3,17 +3,34 @@
# found in the LICENSE file.
DEPS = [
- 'recipe_engine/platform',
'goma',
+ 'recipe_engine/platform',
+ 'recipe_engine/properties',
]
def RunSteps(api):
api.goma.ensure_goma()
- api.goma.start()
+ api.goma.start(env={})
# build something using goma.
- api.goma.stop()
+ api.goma.stop(
+ ninja_log_outdir=api.properties.get('ninja_log_outdir'),
+ ninja_log_compiler=api.properties.get('ninja_log_compiler'),
+ ninja_log_command=api.properties.get('ninja_log_command'),
+ ninja_log_exit_status=api.properties.get('ninja_log_exit_status'),
+ )
def GenTests(api):
for platform in ('linux', 'win', 'mac'):
yield api.test(platform) + api.platform.name(platform)
+
+ properties = {
+ 'build_data_dir': 'build_data_dir',
+ 'ninja_log_outdir': 'build_data_dir',
+ 'ninja_log_compiler': 'goma',
+ 'ninja_log_command': 'ninja -j 500',
+ 'ninja_log_exit_status': 0,
+ }
+
+ yield (api.test('%s_upload_logs' % platform) + api.platform.name(platform) +
+ api.properties.generic(**properties))
« no previous file with comments | « scripts/slave/recipe_modules/goma/api.py ('k') | scripts/slave/recipe_modules/goma/example.expected/linux.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698