scripts/slave/recipe_modules/goma/example.expected/mac.json - Issue 2207273003: Implement upload_logs() in recipe_modules/goma

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/goma/example.expected/mac.json

Issue 2207273003: Implement upload_logs() in recipe_modules/goma (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/goma/api.py ('K') | « scripts/slave/recipe_modules/goma/example.expected/linux.json ('k') | scripts/slave/recipe_modules/goma/example.expected/win.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/goma/example.expected/mac.json

diff --git a/scripts/slave/recipe_modules/goma/example.expected/mac.json b/scripts/slave/recipe_modules/goma/example.expected/mac.json

index e35085846c0a1983842557c18f8bd10670b48a8d..b11f814a5456019920f1f6d99e359d9a4f408afc 100644

--- a/scripts/slave/recipe_modules/goma/example.expected/mac.json

+++ b/scripts/slave/recipe_modules/goma/example.expected/mac.json

@@ -61,6 +61,8 @@

"restart"

"env": {

+ "GOMACTL_CRASH_REPORT_ID_FILE": "/tmp/build_data_dir/crash_report_id_file",

+ "GOMA_DUMP_STATS_FILE": "/tmp/build_data_dir/goma_stats_proto",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "start_goma"

@@ -72,9 +74,29 @@

"[CACHE]/cipd/goma/goma_ctl.py",

"stop"

+ "env": {

+ "GOMACTL_CRASH_REPORT_ID_FILE": "/tmp/build_data_dir/crash_report_id_file",

+ "GOMA_DUMP_STATS_FILE": "/tmp/build_data_dir/goma_stats_proto",

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

+ },

"name": "stop_goma"

{

+ "cmd": [

+ "python",

+ "-u",

+ "upload_goma_logs.py",

+ "--upload-compiler-proxy-info",

+ "--goma-stats-file",

+ "/tmp/build_data_dir/goma_stats_proto",

+ "--goma-crash-report-id-file",

+ "/tmp/build_data_dir/crash_report_id_file",

+ "--build-data-dir",

+ "/tmp/build_data_dir"

+ ],

+ "name": "upload_log"

+ },

+ {

"name": "$result",

"recipe_result": null,

"status_code": 0