Add logcats link in builbot page for android swarming tasks

scripts/slave/recipe_modules/chromium_tests/steps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import re
 import string
-
+import urllib
 
 class Test(object):
   """
   Base class for tests that can be retried after deapplying a previously
   applied patch.
   """
 
   def __init__(self):
     super(Test, self).__init__()
     self._test_runs = {}
@@ skipping 886 matching lines @@
 
     return True, gtest_results.failures
 
   def post_run(self, api, suffix, test_filter=None):
     """Waits for launched test to finish and collects the results."""
     try:
       super(SwarmingGTestTest, self).post_run(
           api, suffix,test_filter=test_filter)
     finally:
       step_result = api.step.active_result
+
+      # If Android swarming tasks, create link for unified logcats

[ghost stip (do not use), 2016/08/04 23:55:58]

I wonder if there is a way to make this more generic so it's not just an android
specific hack. What I'm thinking about is a way to specify a 'link template' in
the buildbot json. We'd read that here and fill in the template if it exists.

'gtest_tests': [
  {
    'test': 'chrome_public_test_apk',
    'swarming': { blah },
    'post_run_links': {
      'shard_index: ${SHARD_INDEX} logcats':
'https://luci-logdog.appspot.com/v/android/swarming/logcats/${TASK_ID}/+/unified_logcats'
    }
  }
]

maybe that's too crazy though

[nicholaslin, 2016/08/05 00:27:17]

Perhaps. Maybe not a link template but maybe a logdog_url flag or something?
Then the android check can be replaced by a logdog_url check. Also we would no
longer have to check for cipd_packages.

+      # https://crbug.com/448050
+      if api.chromium.c.TARGET_PLATFORM == 'android':
+        for task in self._tasks.values():
+          includes_logdog = False
+          if hasattr(task, 'cipd_packages'):
+            func = lambda x: 'logdog/butler' in x[1]
+            includes_logdog = filter(func, task.cipd_packages)
+          if (includes_logdog and hasattr(task, 'trigger_output') 
+              and 'tasks' in task.trigger_output):
+            for test in task.trigger_output['tasks'].values():
+              task_id = test.get('task_id')
+              shard_index = test.get('shard_index')
+              if shard_index is not None and task_id is not None:
+                prefix = 'https://luci-logdog.appspot.com/v/?s='
+                suffix = '%s/%s/%s/%s/+/%s' % ('android', 'swarming', 'logcats',
+                                               task_id, 'unified_logcats')
+                step_result.presentation.links[('shard_index: %d logcats' %
+                                                shard_index)] = (
+                    prefix + urllib.quote_plus(suffix))
+
       # Only upload test results if we have gtest results.
       if (self._upload_test_results and
           hasattr(step_result, 'test_utils') and
           hasattr(step_result.test_utils, 'gtest_results')):
         gtest_results = getattr(step_result.test_utils, 'gtest_results', None)
         if gtest_results and gtest_results.raw:
           parsed_gtest_data = gtest_results.raw
           chrome_revision_cp = api.bot_update.last_returned_properties.get(
               'got_revision_cp', 'x@{#0}')
           chrome_revision = str(api.commit_position.parse_revision(
@@ skipping 819 matching lines @@
           args=args)
       api.gsutil.upload(
           temp_output_dir.join(
               '%s-android-chrome.json' % timestamp_string),
           'chromium-annotated-tests', 'android')
 
 GOMA_TESTS = [
   GTestTest('base_unittests'),
   GTestTest('content_unittests'),
 ]