Unbind video texture from mailbox after copying to WebGL.

Unbind video texture from mailbox after copying to WebGL.

Every time a video is copied to WebGL a new mailbox was associated with
the texture. Since the texture is cached indefinitely the mapping
between textures and mailboxes was growing forever. We can use
glProduceTextureDirectCHROMIUM to unbind textures and mailboxes in this
case.

BUG=634012
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c5fb6dd04f15201c85d37695b647c0a08d8ee053
Cr-Commit-Position: refs/heads/master@{#410204}

[jbauman, 2016-08-04 00:31:50]

Description was changed from

==========
Unbind video texture from mailbox after copying to WebGL.

Every time a video is copied to WebGL a new mailbox was associated with
the texture. Since the texture is cached indefinitely the mapping
between textures and mailboxes was growing forever. We can use
glProduceTextureDirectCHROMIUM to unbind textures and mailboxes in this
case.

BUG=634012
==========

to

==========
Unbind video texture from mailbox after copying to WebGL.

Every time a video is copied to WebGL a new mailbox was associated with
the texture. Since the texture is cached indefinitely the mapping
between textures and mailboxes was growing forever. We can use
glProduceTextureDirectCHROMIUM to unbind textures and mailboxes in this
case.

BUG=634012
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2016-08-04 00:31:56]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 00:32:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 01:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 01:58:03]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-08-04 21:15:22]

jbauman@chromium.org changed reviewers:
+ kbr@chromium.org, piman@chromium.org

[Ken Russell (switch to Gerrit), 2016-08-05 00:56:52]

LGTM

I wish there were a way to write a test for this to prevent regressions.

https://codereview.chromium.org/2207253002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp (right):

https://codereview.chromium.org/2207253002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp:257:
sharedGL->ProduceTextureDirectCHROMIUM(0, textureInfo->fTarget, mailbox->name);
Please add a comment that this disassociates the texture from the mailbox,
preventing memory leaks.

[piman, 2016-08-05 16:25:38]

lgtm

[jbauman, 2016-08-05 20:50:19]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-08-05 20:50:20]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2207253002/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2016-08-05 20:50:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 22:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 22:08:06]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Russell (switch to Gerrit), 2016-08-05 22:26:47]

On 2016/08/05 22:08:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

That looks like a flake to me. John, do you want to file a bug about it?
Re-CQ'ing.

[Ken Russell (switch to Gerrit), 2016-08-05 22:26:52]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-08-05 22:27:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 23:03:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-05 23:05:02]

Description was changed from

==========
Unbind video texture from mailbox after copying to WebGL.

Every time a video is copied to WebGL a new mailbox was associated with
the texture. Since the texture is cached indefinitely the mapping
between textures and mailboxes was growing forever. We can use
glProduceTextureDirectCHROMIUM to unbind textures and mailboxes in this
case.

BUG=634012
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Unbind video texture from mailbox after copying to WebGL.

Every time a video is copied to WebGL a new mailbox was associated with
the texture. Since the texture is cached indefinitely the mapping
between textures and mailboxes was growing forever. We can use
glProduceTextureDirectCHROMIUM to unbind textures and mailboxes in this
case.

BUG=634012
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c5fb6dd04f15201c85d37695b647c0a08d8ee053
Cr-Commit-Position: refs/heads/master@{#410204}
==========

[commit-bot: I haz the power, 2016-08-05 23:05:06]

Patchset 2 (id:??) landed as
https://crrev.com/c5fb6dd04f15201c85d37695b647c0a08d8ee053
Cr-Commit-Position: refs/heads/master@{#410204}