Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 220723012: Add a missing null check to LinkStyle::process() (Closed)

Created:
6 years, 8 months ago by Hajime Morrita
Modified:
6 years, 8 months ago
Reviewers:
esprehn
CC:
blink-reviews, dglazkov+blink, gavinp+prerender_chromium.org, adamk+blink_chromium.org
Visibility:
Public.

Description

Add a missing null check to LinkStyle::process() This is a speculative fix for crashes that are reported from wild. BUG=358844 R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Hajime Morrita
PTAL? Honestly I have no good idea what's going on. Probably the frame is detached ...
6 years, 8 months ago (2014-04-02 01:42:59 UTC) #1
esprehn
lgtm, sucks we can't figure out what's really going on.
6 years, 8 months ago (2014-04-02 19:32:20 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 8 months ago (2014-04-02 19:34:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/220723012/1
6 years, 8 months ago (2014-04-02 19:34:26 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 19:42:10 UTC) #5
Message was sent while issue was closed.
Change committed as 170689

Powered by Google App Engine
This is Rietveld 408576698