Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2207183002: [wasm] Require global names to be validate UTF-8. (Closed)

Created:
4 years, 4 months ago by titzer
Modified:
4 years, 4 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Require global names to be validate UTF-8. R=ahaas@chromium.org,bradnelson@chromium.org BUG=chromium:628542 Committed: https://crrev.com/6cf621ec891edb0c56ac1773a0fd57ee7a296713 Cr-Commit-Position: refs/heads/master@{#38317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/wasm/module-decoder.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
titzer
4 years, 4 months ago (2016-08-03 22:22:45 UTC) #1
bradnelson
lgtm
4 years, 4 months ago (2016-08-03 22:44:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207183002/1
4 years, 4 months ago (2016-08-03 22:53:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 22:54:49 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 22:55:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cf621ec891edb0c56ac1773a0fd57ee7a296713
Cr-Commit-Position: refs/heads/master@{#38317}

Powered by Google App Engine
This is Rietveld 408576698