[DevTools] Removed InspectorTest.invokePageFunctionPromise

[DevTools] Removed InspectorTest.invokePageFunctionPromise

BUG=632875
R=dgozman@chromium.org

Committed: https://crrev.com/55da79583bf83778309007c14f53092295cc0a7d
Cr-Commit-Position: refs/heads/master@{#410114}

[kozy, 2016-08-03 21:38:00]

Dmitry, please take a look!

[dgozman, 2016-08-03 22:46:58]

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js
(right):

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js:188:
.then((success) => success ? undefined : onCacheStorageError("Could not find
cache " + cacheName))
This looks strange. Let's revert to previous version?

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
(right):

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:76: if
(!error)
Let's log something and completeTest otherwise, or we'll get timeouts without
any results. And do the same in evaluateInPage.

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:77:
callback(InspectorTest.runtimeModel.createRemoteObject(result), wasThrown);
There is no way to pass two arguments to a promise callback. Let's handle
wasThrown as an error.

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/elements/hide-shortcut.html
(right):

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/elements/hide-shortcut.html:131:
InspectorTest.addResult("visibility: " + result.value + ";");
Can we fix evaluateInPagePromise to pass the value instead? Maybe in a
follow-up?

[kozy, 2016-08-03 23:48:39]

All done. Please take a look!

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js
(right):

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js:188:
.then((success) => success ? undefined : onCacheStorageError("Could not find
cache " + cacheName))
On 2016/08/03 22:46:57, dgozman wrote:
> This looks strange. Let's revert to previous version?

Done.

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
(right):

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:76: if
(!error)
On 2016/08/03 22:46:58, dgozman wrote:
> Let's log something and completeTest otherwise, or we'll get timeouts without
> any results. And do the same in evaluateInPage.

Done.

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:77:
callback(InspectorTest.runtimeModel.createRemoteObject(result), wasThrown);
On 2016/08/03 22:46:58, dgozman wrote:
> There is no way to pass two arguments to a promise callback. Let's handle
> wasThrown as an error.

Done.

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/elements/hide-shortcut.html
(right):

https://codereview.chromium.org/2207163002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/elements/hide-shortcut.html:131:
InspectorTest.addResult("visibility: " + result.value + ";");
On 2016/08/03 22:46:58, dgozman wrote:
> Can we fix evaluateInPagePromise to pass the value instead? Maybe in a
> follow-up?

I think it can break other tests, I'll try to address it in followup.

[kozy, 2016-08-03 23:49:01]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 23:49:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-08-04 00:04:40]

lgtm

https://codereview.chromium.org/2207163002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
(right):

https://codereview.chromium.org/2207163002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:80:
rejectCallback(InspectorTest.runtimeModel.createRemoteObject(result));
Let's completeTest in this case as well instead of rejecting.

[kozy, 2016-08-04 00:11:04]

All done!

https://codereview.chromium.org/2207163002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
(right):

https://codereview.chromium.org/2207163002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:80:
rejectCallback(InspectorTest.runtimeModel.createRemoteObject(result));
On 2016/08/04 00:04:40, dgozman wrote:
> Let's completeTest in this case as well instead of rejecting.

Done.

[kozy, 2016-08-04 00:11:26]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-04 00:11:26]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2207163002/#ps60001
(title: "a")

[commit-bot: I haz the power, 2016-08-04 00:12:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 01:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 01:38:23]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kozy, 2016-08-04 02:28:06]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-08-04 02:28:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 03:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 03:45:51]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kozy, 2016-08-05 17:10:37]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-05 17:10:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2207163002/#ps80001
(title: "a")

[commit-bot: I haz the power, 2016-08-05 17:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 18:22:31]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-05 18:25:23]

Description was changed from

==========
[DevTools] Removed InspectorTest.invokePageFunctionPromise

BUG=632875
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed InspectorTest.invokePageFunctionPromise

BUG=632875
R=dgozman@chromium.org

Committed: https://crrev.com/55da79583bf83778309007c14f53092295cc0a7d
Cr-Commit-Position: refs/heads/master@{#410114}
==========

[commit-bot: I haz the power, 2016-08-05 18:25:24]

Patchset 5 (id:??) landed as
https://crrev.com/55da79583bf83778309007c14f53092295cc0a7d
Cr-Commit-Position: refs/heads/master@{#410114}