Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 220713003: Add UseCounter entry for SVGForeignObjectElement (Closed)

Created:
6 years, 8 months ago by davve
Modified:
6 years, 8 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add UseCounter entry for SVGForeignObjectElement There have been discussions about removing foreignObject and instead allow an html element with position and dimensions inside svg. Knowing how popular foreignObject is may be useful in such discussions. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davve
I see that there is some considerable skew in how the SVGSVGElement counter compares to ...
6 years, 8 months ago (2014-04-01 11:18:21 UTC) #1
Stephen Chennney
lgtm I agree that we do not need to be very concerned about object creation ...
6 years, 8 months ago (2014-04-01 12:05:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/220713003/1
6 years, 8 months ago (2014-04-01 12:05:59 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 13:14:56 UTC) #4
Message was sent while issue was closed.
Change committed as 170561

Powered by Google App Engine
This is Rietveld 408576698