Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2207103003: Removing unused resources from chrome/java/res (Closed)

Created:
4 years, 4 months ago by estevenson
Modified:
4 years, 4 months ago
Reviewers:
Ted C, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing unused resources from chrome/java/res This will reduce the number of lint warnings generated during builds. BUG=621773 Committed: https://crrev.com/9e4be9ba438612c55668fc95a55000e4a4cc0869 Cr-Commit-Position: refs/heads/master@{#410186}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Addressed additional lint warnings #

Total comments: 2

Patch Set 4 : Added comment about suppression #

Total comments: 2

Patch Set 5 : Added TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -24 lines) Patch
M build/android/lint/suppressions.xml View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
D chrome/android/java/res/drawable/notification_icon_bg.xml View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/res/values/dimens.xml View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
estevenson
4 years, 4 months ago (2016-08-04 19:37:34 UTC) #7
agrieve
lgtm https://codereview.chromium.org/2207103003/diff/40001/build/android/lint/suppressions.xml File build/android/lint/suppressions.xml (right): https://codereview.chromium.org/2207103003/diff/40001/build/android/lint/suppressions.xml#newcode112 build/android/lint/suppressions.xml:112: <ignore path="chrome/android/java/res/xml/network_security_config.xml" /> nit: add a comment as ...
4 years, 4 months ago (2016-08-05 03:27:41 UTC) #8
agrieve
+tedchoc
4 years, 4 months ago (2016-08-05 03:28:13 UTC) #10
estevenson
https://codereview.chromium.org/2207103003/diff/40001/build/android/lint/suppressions.xml File build/android/lint/suppressions.xml (right): https://codereview.chromium.org/2207103003/diff/40001/build/android/lint/suppressions.xml#newcode112 build/android/lint/suppressions.xml:112: <ignore path="chrome/android/java/res/xml/network_security_config.xml" /> On 2016/08/05 03:27:41, agrieve wrote: > ...
4 years, 4 months ago (2016-08-05 13:59:44 UTC) #11
Ted C
lgtm https://codereview.chromium.org/2207103003/diff/60001/build/android/lint/suppressions.xml File build/android/lint/suppressions.xml (right): https://codereview.chromium.org/2207103003/diff/60001/build/android/lint/suppressions.xml#newcode112 build/android/lint/suppressions.xml:112: <!-- This file isn't used if the target ...
4 years, 4 months ago (2016-08-05 20:48:33 UTC) #12
estevenson
https://codereview.chromium.org/2207103003/diff/60001/build/android/lint/suppressions.xml File build/android/lint/suppressions.xml (right): https://codereview.chromium.org/2207103003/diff/60001/build/android/lint/suppressions.xml#newcode112 build/android/lint/suppressions.xml:112: <!-- This file isn't used if the target SDK ...
4 years, 4 months ago (2016-08-05 21:21:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207103003/80001
4 years, 4 months ago (2016-08-05 21:25:29 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-05 22:16:27 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 22:18:27 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9e4be9ba438612c55668fc95a55000e4a4cc0869
Cr-Commit-Position: refs/heads/master@{#410186}

Powered by Google App Engine
This is Rietveld 408576698