xfa/fwl/basewidget/fwl_editimp.h - Issue 2207093005: Use smart pointers for class owned pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/basewidget/fwl_editimp.h

Issue 2207093005: Use smart pointers for class owned pointers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/basewidget/fwl_editimp.h

diff --git a/xfa/fwl/basewidget/fwl_editimp.h b/xfa/fwl/basewidget/fwl_editimp.h

index 3f7a3862dde7de6941ac7c38cafcadf65f1dca20..e17a4cfc0942b35133e285dbadce0e290ce5a238 100644

--- a/xfa/fwl/basewidget/fwl_editimp.h

+++ b/xfa/fwl/basewidget/fwl_editimp.h

@@ -152,7 +152,7 @@ class CFWL_EditImp : public CFWL_WidgetImp {

FX_FLOAT m_fVAlignOffset;

FX_FLOAT m_fScrollOffsetX;

FX_FLOAT m_fScrollOffsetY;

- CFDE_TxtEdtEngine* m_pEdtEngine;

+ std::unique_ptr<CFDE_TxtEdtEngine> m_pEdtEngine;

FX_BOOL m_bLButtonDown;

int32_t m_nSelStart;

int32_t m_nLimit;