Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2207053002: Revert of Define printer configuration objects for Chrome OS. (Closed)

Created:
4 years, 4 months ago by aboxhall
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, stevenjb, xdai1, sky, skau
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, adlr, Lei Zhang, briannorris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Define printer configuration objects for Chrome OS. (patchset #11 id:200001 of https://codereview.chromium.org/2161933003/ ) Reason for revert: This appears to be causing ASAN test failures: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15003 Original issue's description: > Define printer configuration objects for Chrome OS. > > Models will represent complete information required to setup a printer. > They will be stored in local storage until sync can be implemented with > the Chrome Sync team. > > BUG=616853 > > TEST=Unit tests for all object translation code. > > Committed: https://crrev.com/2b3975549595c92fa10c8a93b12d3aaefa2e9406 > Cr-Commit-Position: refs/heads/master@{#409463} TBR=xdai@chromium.org,stevenjb@chromium.org,sky@chromium.org,thestig@chromium.org,skau@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=616853 Committed: https://crrev.com/6481656e72dc20b2842df750f4ccd626566c6bc4 Cr-Commit-Position: refs/heads/master@{#409526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -587 lines) Patch
D chrome/browser/chromeos/printing/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/printing/printer_pref_manager.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/chromeos/printing/printer_pref_manager.cc View 1 chunk +0 lines, -107 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chromeos/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
D chromeos/printing/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chromeos/printing/printer_configuration.h View 1 chunk +0 lines, -104 lines 0 comments Download
D chromeos/printing/printer_configuration.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D chromeos/printing/printer_translator.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chromeos/printing/printer_translator.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D chromeos/printing/printer_translator_unittest.cc View 1 chunk +0 lines, -121 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aboxhall
Created Revert of Define printer configuration objects for Chrome OS.
4 years, 4 months ago (2016-08-03 16:21:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207053002/1
4 years, 4 months ago (2016-08-03 16:21:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 16:23:37 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6481656e72dc20b2842df750f4ccd626566c6bc4 Cr-Commit-Position: refs/heads/master@{#409526}
4 years, 4 months ago (2016-08-03 16:25:47 UTC) #6
skau
4 years, 4 months ago (2016-08-03 16:59:37 UTC) #7
Message was sent while issue was closed.
On 2016/08/03 16:25:47, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/6481656e72dc20b2842df750f4ccd626566c6bc4
> Cr-Commit-Position: refs/heads/master@{#409526}

lgtm

Sorry.  The blamed CL is the cause of the ASAN failures.

Powered by Google App Engine
This is Rietveld 408576698