Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2207033002: Split xfa_layout_appadapter (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Split xfa_layout_appadapter This moves the needed traverse strategies into their own files, removes the unused one and cleans up the includes. Committed: https://pdfium.googlesource.com/pdfium/+/6ea5ba035a396bf0956b4b4ab3a5b3ee33b6c546

Patch Set 1 #

Patch Set 2 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -125 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M xfa.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cscript_layoutpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_layoutitem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/cxfa_layoutitem.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/cxfa_layoutprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
A xfa/fxfa/parser/cxfa_traversestrategy_contentareacontainerlayoutitem.h View 1 chunk +44 lines, -0 lines 0 comments Download
A xfa/fxfa/parser/cxfa_traversestrategy_contentlayoutitem.h View 1 chunk +30 lines, -0 lines 0 comments Download
D xfa/fxfa/parser/xfa_layout_appadapter.h View 1 chunk +0 lines, -81 lines 0 comments Download
D xfa/fxfa/parser/xfa_layout_appadapter.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
dsinclair
PTAL.
4 years, 4 months ago (2016-08-03 15:56:29 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-03 16:53:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207033002/20001
4 years, 4 months ago (2016-08-03 16:56:01 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 17:20:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/6ea5ba035a396bf0956b4b4ab3a5b3ee33b6...

Powered by Google App Engine
This is Rietveld 408576698