Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: tools/bots/compiler.py

Issue 220703003: Always print the runtime as part of the stepname (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
===================================================================
--- tools/bots/compiler.py (revision 34584)
+++ tools/bots/compiler.py (working copy)
@@ -140,16 +140,17 @@
'ff', 'drt', 'dartium']
-def TestStepName(name, flags):
+def TestStepName(name, runtime, flags):
# Filter out flags with '=' as this breaks the /stats feature of the
# build bot.
flags = [x for x in flags if not '=' in x]
- return ('%s tests %s' % (name, ' '.join(flags))).strip()
+ step_name = '%s-%s tests %s' % (name, runtime, ' '.join(flags))
+ return step_name.strip()
IsFirstTestStepCall = True
def TestStep(name, mode, system, compiler, runtime, targets, flags, arch):
- step_name = TestStepName(name, flags)
+ step_name = TestStepName(name, runtime, flags)
with bot.BuildStep(step_name, swallow_error=True):
sys.stdout.flush()
if NeedsXterm(compiler, runtime) and system == 'linux':
@@ -266,7 +267,7 @@
['html', 'pkg', 'samples'], flags, arch)
else:
# Run the default set of test suites.
- TestStep("%s-%s" % (compiler, runtime), mode, system, compiler,
+ TestStep(compiler, mode, system, compiler,
runtime, [], flags, arch)
if compiler == 'dart2js':
@@ -279,10 +280,10 @@
# Run the extra tests in checked mode, but only on linux/d8.
# Other systems have less resources and tend to time out.
extras_flags = extras_flags + ['--host-checked']
- TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras,
+ TestStep('dart2js_extra', mode, system, 'dart2js', runtime, extras,
extras_flags, arch)
- TestStep("try_dart", mode, system, 'dart2js', runtime, ['try'],
+ TestStep('try_dart', mode, system, 'dart2js', runtime, ['try'],
extras_flags, arch)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698