Always print the runtime as part of the stepname

tools/bots/compiler.py

Index: tools/bots/compiler.py
===================================================================
--- tools/bots/compiler.py	(revision 34584)
+++ tools/bots/compiler.py	(working copy)
@@ -140,16 +140,17 @@
                      'ff', 'drt', 'dartium']
 
 
-def TestStepName(name, flags):
+def TestStepName(name, runtime, flags):
   # Filter out flags with '=' as this breaks the /stats feature of the
   # build bot.
   flags = [x for x in flags if not '=' in x]
-  return ('%s tests %s' % (name, ' '.join(flags))).strip()
+  step_name = '%s-%s tests %s' % (name, runtime, ' '.join(flags))
+  return step_name.strip()
 
 
 IsFirstTestStepCall = True
 def TestStep(name, mode, system, compiler, runtime, targets, flags, arch):
-  step_name = TestStepName(name, flags)
+  step_name = TestStepName(name, runtime, flags)
   with bot.BuildStep(step_name, swallow_error=True):
     sys.stdout.flush()
     if NeedsXterm(compiler, runtime) and system == 'linux':
@@ -266,7 +267,7 @@
              ['html', 'pkg', 'samples'], flags, arch)
   else:
     # Run the default set of test suites.
-    TestStep("%s-%s" % (compiler, runtime), mode, system, compiler,
+    TestStep('%s' % compiler, mode, system, compiler,

[Bill Hesse, 2014/04/01 12:04:03]

Is '%s' % compiler doing anything special like 'toString', or can we just say
compiler instead.

[ricow1, 2014/04/01 12:07:35]

Done.

              runtime, [], flags, arch)
 
     if compiler == 'dart2js':
@@ -279,10 +280,10 @@
         # Run the extra tests in checked mode, but only on linux/d8.
         # Other systems have less resources and tend to time out.
         extras_flags = extras_flags + ['--host-checked']
-      TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras,
+      TestStep('dart2js_extra', mode, system, 'dart2js', runtime, extras,
                extras_flags, arch)
 
-      TestStep("try_dart", mode, system, 'dart2js', runtime, ['try'],
+      TestStep('try_dart-%s', mode, system, 'dart2js', runtime, ['try'],

[Bill Hesse, 2014/04/01 12:04:03]

I don't think you want the %s without a % applied to it, do you?

[ricow1, 2014/04/01 12:07:35]

Done.

                extras_flags, arch)