Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2206953004: During generation of the version.cc file, read the current Git hash. (Closed)

Created:
4 years, 4 months ago by Chinmay
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

During generation of the version.cc file, read the current Git hash. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9a68bad6fdb8d799aae3c502b5e7094639de1c97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M runtime/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Chinmay
4 years, 4 months ago (2016-08-03 20:09:14 UTC) #2
rmacnak
lgtm
4 years, 4 months ago (2016-08-03 20:28:44 UTC) #3
Florian Schneider
4 years, 4 months ago (2016-08-03 21:16:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a68bad6fdb8d799aae3c502b5e7094639de1c97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698