Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2206933002: Revert of Unified the code to upload goma-related information. (Closed)

Created:
4 years, 4 months ago by Yoshisato Yanagisawa
Modified:
4 years, 4 months ago
Reviewers:
ukai, tikuta, shinyak
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Unified the code to upload goma-related information. (patchset #2 id:20001 of https://codereview.chromium.org/2201203003/ ) Reason for revert: broke https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.9%20Goma%20Canary%20%28dbg%29/builds/25223/steps/compile/logs/stdio Original issue's description: > Unified the code to upload goma-related information. > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/489cc86abae972ea7e12e81ec194b532d7a6e14f TBR=ukai@chromium.org,shinyak@chromium.org,tikuta@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/tools/build/+/1e8492e20d0a921d3f9888379010b67203ee81c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -36 lines) Patch
M scripts/slave/compile.py View 3 chunks +46 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Yoshisato Yanagisawa
Created Revert of Unified the code to upload goma-related information.
4 years, 4 months ago (2016-08-03 06:31:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206933002/1
4 years, 4 months ago (2016-08-03 06:31:26 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 06:31:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/1e8492e20d0a921d3f98...

Powered by Google App Engine
This is Rietveld 408576698