Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220693002: Protect EventListener from being deleted before it is passed into InspectorInstrumentation::didRemo… (Closed)

Created:
6 years, 8 months ago by yurys
Modified:
6 years, 8 months ago
Reviewers:
aandrey, pfeldman
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Protect EventListener from being deleted before it is passed into InspectorInstrumentation::didRemoveEventListener BUG=358467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170543

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/events/EventTarget.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yurys
6 years, 8 months ago (2014-04-01 08:05:25 UTC) #1
aandrey
lgtm https://codereview.chromium.org/220693002/diff/1/Source/core/events/EventTarget.cpp File Source/core/events/EventTarget.cpp (right): https://codereview.chromium.org/220693002/diff/1/Source/core/events/EventTarget.cpp#newcode105 Source/core/events/EventTarget.cpp:105: RefPtr protect(listener); Template argument to RefPtr<>?
6 years, 8 months ago (2014-04-01 08:09:55 UTC) #2
yurys
https://codereview.chromium.org/220693002/diff/1/Source/core/events/EventTarget.cpp File Source/core/events/EventTarget.cpp (right): https://codereview.chromium.org/220693002/diff/1/Source/core/events/EventTarget.cpp#newcode105 Source/core/events/EventTarget.cpp:105: RefPtr protect(listener); On 2014/04/01 08:09:56, aandrey wrote: > Template ...
6 years, 8 months ago (2014-04-01 08:11:10 UTC) #3
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 8 months ago (2014-04-01 08:11:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/220693002/20001
6 years, 8 months ago (2014-04-01 08:11:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 09:29:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 09:29:12 UTC) #7
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 8 months ago (2014-04-01 09:57:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/220693002/20001
6 years, 8 months ago (2014-04-01 09:57:57 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 10:50:54 UTC) #10
Message was sent while issue was closed. 
Change committed as 170543

Powered by Google App Engine
This is Rietveld 408576698