Remove webkitpy/common/config/urls.py

third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

Index: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
index 81eefb7bedde0c504fab84dff86166e8dcd743e7..a968a538c72bfb9febabf8b41fa434d62da2841a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
@@ -37,7 +37,6 @@ import datetime
 
 from webkitpy.common import find_files
 from webkitpy.common.checkout.scm.detection import SCMDetector
-from webkitpy.common.config.urls import view_source_url
 from webkitpy.common.host import Host
 from webkitpy.common.net.file_uploader import FileUploader
 from webkitpy.performance_tests.perftest import PerfTestFactory
@@ -294,7 +293,8 @@ class PerfTestsRunner(object):
                 path = test.test_name_without_file_extension().split('/')
                 for i in range(0, len(path)):
                     is_last_token = i + 1 == len(path)
-                    url = view_source_url('PerformanceTests/' + (test.test_name() if is_last_token else '/'.join(path[0:i + 1])))
+                    url = self.view_source_url(
+                        'PerformanceTests/' + (test.test_name() if is_last_token else '/'.join(path[0:i + 1])))
                     tests.setdefault(path[i], {'url': url})
                     current_test = tests[path[i]]
                     if is_last_token:
@@ -308,6 +308,10 @@ class PerfTestsRunner(object):
         return contents
 
     @staticmethod
+    def view_source_url(path_from_blink):
+        return "https://src.chromium.org/viewvc/blink/trunk/%s" % path_from_blink

[qyearsley, 2016/08/03 18:13:53]

Also, it seems likely that this should be updated to
"https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/%s".
OK to do this in this CL, or should this be done in a separate CL?

[Dirk Pranke, 2016/08/09 00:05:15]

whichever you like. I'd probably do it in this CL.

[qyearsley, 2016/08/09 17:22:10]

Done

+
+    @staticmethod
     def _datetime_in_ES5_compatible_iso_format(datetime):
         return datetime.strftime('%Y-%m-%dT%H:%M:%S.%f')