Remove webkitpy/common/config/urls.py

Remove webkitpy/common/config/urls.py

This change includes moving the last remaining function in urls.py
to the place where it's used (perftestsrunner.py).

This CL also updates this URL to https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/%s, since I believe the old URL won't work for changes after the Blink/Chromium merge.

Committed: https://crrev.com/c5ce1b558dc0031cd6f10f893a3082e9de9f04fd
Cr-Commit-Position: refs/heads/master@{#410753}

[qyearsley, 2016-08-03 18:13:15]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-08-03 18:13:53]

https://codereview.chromium.org/2206913003/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
(right):

https://codereview.chromium.org/2206913003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:312:
return "https://src.chromium.org/viewvc/blink/trunk/%s" % path_from_blink
Also, it seems likely that this should be updated to
"https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/%s".
OK to do this in this CL, or should this be done in a separate CL?

[Dirk Pranke, 2016-08-09 00:05:15]

lgtm.

https://codereview.chromium.org/2206913003/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
(right):

https://codereview.chromium.org/2206913003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:312:
return "https://src.chromium.org/viewvc/blink/trunk/%s" % path_from_blink
On 2016/08/03 18:13:53, qyearsley wrote:
> Also, it seems likely that this should be updated to
>
"https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/%s".
> OK to do this in this CL, or should this be done in a separate CL?

whichever you like. I'd probably do it in this CL.

[qyearsley, 2016-08-09 17:21:45]

Description was changed from

==========
Remove webkitpy/common/config/urls.py

This change includes moving the last remaining function in urls.py
to the place where it's used (perftestsrunner.py).
==========

to

==========
Remove webkitpy/common/config/urls.py

This change includes moving the last remaining function in urls.py
to the place where it's used (perftestsrunner.py).

This CL also updates this URL to
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/%s,
since I believe the old URL won't work for changes after the Blink/Chromium
merge.
==========

[qyearsley, 2016-08-09 17:22:10]

https://codereview.chromium.org/2206913003/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
(right):

https://codereview.chromium.org/2206913003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:312:
return "https://src.chromium.org/viewvc/blink/trunk/%s" % path_from_blink
On 2016/08/09 at 00:05:15, Dirk Pranke wrote:
> On 2016/08/03 18:13:53, qyearsley wrote:
> > Also, it seems likely that this should be updated to
> >
"https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/%s".
> > OK to do this in this CL, or should this be done in a separate CL?
> 
> whichever you like. I'd probably do it in this CL.

Done

[qyearsley, 2016-08-09 17:22:13]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-08-09 17:22:14]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2206913003/#ps20001
(title: "Update source view URL")

[commit-bot: I haz the power, 2016-08-09 17:22:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 18:29:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-09 18:31:19]

Description was changed from

==========
Remove webkitpy/common/config/urls.py

This change includes moving the last remaining function in urls.py
to the place where it's used (perftestsrunner.py).

This CL also updates this URL to
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/%s,
since I believe the old URL won't work for changes after the Blink/Chromium
merge.
==========

to

==========
Remove webkitpy/common/config/urls.py

This change includes moving the last remaining function in urls.py
to the place where it's used (perftestsrunner.py).

This CL also updates this URL to
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/%s,
since I believe the old URL won't work for changes after the Blink/Chromium
merge.

Committed: https://crrev.com/c5ce1b558dc0031cd6f10f893a3082e9de9f04fd
Cr-Commit-Position: refs/heads/master@{#410753}
==========

[commit-bot: I haz the power, 2016-08-09 18:31:20]

Patchset 2 (id:??) landed as
https://crrev.com/c5ce1b558dc0031cd6f10f893a3082e9de9f04fd
Cr-Commit-Position: refs/heads/master@{#410753}