Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2206913002: X87: [turbofan] Fix invalid comparison operator narrowing. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Fix invalid comparison operator narrowing. port a758144329b7ddda258e41ea5d8abfca8595e34c (r38231) original commit message: When we narrow a signed32 comparison to uint8 or uint16 representation, we also need to change the condition to unsigned comparisons otherwise the comparison will be done on int16/int8 which interprets the narrowed bits wrong. BUG= Committed: https://crrev.com/b412b789d33bc314772b84d79cf35caba20d8b18 Cr-Commit-Position: refs/heads/master@{#38274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 3 chunks +35 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-03 06:15:44 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2016-08-03 06:26:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206913002/1
4 years, 4 months ago (2016-08-03 06:38:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 07:09:42 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 07:13:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b412b789d33bc314772b84d79cf35caba20d8b18
Cr-Commit-Position: refs/heads/master@{#38274}

Powered by Google App Engine
This is Rietveld 408576698