Issue 2206873004: Move the serial_port native code

Issue 2206873004: Move the serial_port native code (Closed)

Created:
4 years, 4 months ago by Søren Gjesse

Modified:
4 years, 4 months ago

Reviewers:
Jakob Roland Andersen

CC:
dartino-code-reviews_googlegroups.com, karlklose

Base URL:
git@github.com:dartino/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Move the serial_port native code The latest version of the Dart VM require native code for native extensions to be in the same directory as the Dart file inporting it. Closes #588 BUG= https://github.com/dartino/sdk/issues/588 R=jakobr@google.com BUG= Committed: https://github.com/dartino/sdk/commit/af933f98d71ef374a475fa6b4e7bd7cc34a280cd

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -7 lines)			Patch
M	.gitignore	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/mdns/lib/src/native_extension_api.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/serial_port/README.google	View	1 chunk	+3 lines, -2 lines	0 comments	Download
A +	third_party/serial_port/lib/libserial_port.dylib.sha1	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	third_party/serial_port/lib/libserial_port.so.sha1	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	third_party/serial_port/lib/serial_port.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	third_party/serial_port/lib/src/libserial_port.dylib.sha1	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	third_party/serial_port/lib/src/libserial_port.so.sha1	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Søren Gjesse

4 years, 4 months ago (2016-08-03 13:09:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
af933f98d71ef374a475fa6b4e7bd7cc34a280cd (presubmit successful).