third_party/WebKit/Source/core/loader/NavigationScheduler.h - Issue 2206843003: Disable navigations in the unload handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/NavigationScheduler.h

Issue 2206843003: Disable navigations in the unload handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/NavigationScheduler.h

diff --git a/third_party/WebKit/Source/core/loader/NavigationScheduler.h b/third_party/WebKit/Source/core/loader/NavigationScheduler.h

index cc8f867ad94fd39fdb94fce9121e9db99c814a7e..28b6a5885b816cc06ff772f9fd1d721145b0a030 100644

--- a/third_party/WebKit/Source/core/loader/NavigationScheduler.h

+++ b/third_party/WebKit/Source/core/loader/NavigationScheduler.h

@@ -109,15 +109,15 @@ private:

static unsigned s_navigationDisableCount;

};

-class CORE_EXPORT NavigationCounterForUnload {

- WTF_MAKE_NONCOPYABLE(NavigationCounterForUnload);

+class CORE_EXPORT NavigationDisablerForUnload {

dcheng 2016/08/16 22:32:03 Can we just use NavigationDisablerForBeforeUnload,

+ WTF_MAKE_NONCOPYABLE(NavigationDisablerForUnload);

STACK_ALLOCATED();

public:

- NavigationCounterForUnload()

+ NavigationDisablerForUnload()

{

s_inUnloadHandler++;

}

- ~NavigationCounterForUnload()

+ ~NavigationDisablerForUnload()

{

DCHECK(s_inUnloadHandler);

s_inUnloadHandler--;