Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 2206823004: Remove "Go Back/Forward" from keyboard overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix indent Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index dbfd2ca7eb7b065f01d64ae1ff33ba607b0a1196..6da32e17680fcf235a9ba40eda70ee8647921b25 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -36,6 +36,7 @@
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/tabs/tab_strip_model_utils.h"
#include "chrome/browser/ui/webui/inspect_ui.h"
+#include "chrome/common/chrome_features.h"
#include "chrome/common/content_restriction.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/profiling.h"
@@ -115,10 +116,6 @@ bool HasInternalURL(const NavigationEntry* entry) {
namespace chrome {
-const base::Feature kBackspaceGoesBackFeature {
- "BackspaceGoesBack", base::FEATURE_DISABLED_BY_DEFAULT
-};
-
///////////////////////////////////////////////////////////////////////////////
// BrowserCommandController, public:
@@ -318,7 +315,7 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
switch (id) {
// Navigation commands
case IDC_BACKSPACE_BACK:
- if (base::FeatureList::IsEnabled(kBackspaceGoesBackFeature))
+ if (base::FeatureList::IsEnabled(features::kBackspaceGoesBackFeature))
GoBack(browser_, disposition);
else
browser_->window()->MaybeShowNewBackShortcutBubble(false);
@@ -328,7 +325,7 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
GoBack(browser_, disposition);
break;
case IDC_BACKSPACE_FORWARD:
- if (base::FeatureList::IsEnabled(kBackspaceGoesBackFeature))
+ if (base::FeatureList::IsEnabled(features::kBackspaceGoesBackFeature))
GoForward(browser_, disposition);
else
browser_->window()->MaybeShowNewBackShortcutBubble(true);
« no previous file with comments | « chrome/browser/resources/chromeos/keyboard_overlay.js ('k') | chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698