Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2552)

Unified Diff: chrome/browser/resources/chromeos/keyboard_overlay.js

Issue 2206823004: Remove "Go Back/Forward" from keyboard overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_command_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/keyboard_overlay.js
diff --git a/chrome/browser/resources/chromeos/keyboard_overlay.js b/chrome/browser/resources/chromeos/keyboard_overlay.js
index fca7f74ce737a2bd089cbb8e905ba5b5c478f46e..0f08c98388071ba61c2365a9beb24370ade08ef2 100644
--- a/chrome/browser/resources/chromeos/keyboard_overlay.js
+++ b/chrome/browser/resources/chromeos/keyboard_overlay.js
@@ -555,6 +555,15 @@ function update(modifiers, normModifiers) {
classes.push('keyboard-overlay-key-background');
+ if (shortcutId && (shortcutId == 'keyboardOverlayGoBack' ||
Lei Zhang 2016/08/03 23:03:43 I'm not JS expert, so take this with a grain of sa
afakhry 2016/08/04 16:44:59 I'm not a JS person either, but you were right, no
+ shortcutId == 'keyboardOverlayGoForward')) {
+ // If the "backspace key goes back" experiment is not enabled, then we
+ // clear the shortcuts for Backspace and Shift+Backspace to go back or
+ // forward respectively.
+ if (!loadTimeData.getBoolean('backspaceGoesBackFeatureEnabled'))
Lei Zhang 2016/08/03 23:03:43 Tack this on to the if statement above?
afakhry 2016/08/04 16:44:59 Done.
+ shortcutId = null;
+ }
+
if (shortcutId) {
classes.push('is-shortcut');
classes.push('keyboard-overlay-shortcut-key-background');
« no previous file with comments | « no previous file | chrome/browser/ui/browser_command_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698