Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2206823003:
Fix dtor bug in SkLights (Closed)
|
Created:
4 years, 4 months ago by robertphillips Modified:
4 years, 4 months ago CC:
reviews_skia.org, vjiaoblack Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionFix dtor bug in SkLights
The overriding problem was that the SkTDArray wasn't calling the SkLight destructors.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206823003
Committed: https://skia.googlesource.com/skia/+/a746f7894ae96558abd0775aef68d895f99dd53b
Patch Set 1 #Patch Set 2 : update #Messages
Total messages: 19 (13 generated)
Description was changed from ========== Fix dtor bug in SkLights ========== to ========== Fix dtor bug in SkLights GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206823003 ==========
Description was changed from ========== Fix dtor bug in SkLights GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206823003 ========== to ========== Fix dtor bug in SkLights The overriding problem was that the SkTDArray wasn't calling the SkLight destructors. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206823003 ==========
robertphillips@google.com changed reviewers: + egdaniel@google.com
lgtm
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== Fix dtor bug in SkLights The overriding problem was that the SkTDArray wasn't calling the SkLight destructors. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206823003 ========== to ========== Fix dtor bug in SkLights The overriding problem was that the SkTDArray wasn't calling the SkLight destructors. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206823003 ==========
robertphillips@google.com changed reviewers: + reed@google.com
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix dtor bug in SkLights The overriding problem was that the SkTDArray wasn't calling the SkLight destructors. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206823003 ========== to ========== Fix dtor bug in SkLights The overriding problem was that the SkTDArray wasn't calling the SkLight destructors. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206823003 Committed: https://skia.googlesource.com/skia/+/a746f7894ae96558abd0775aef68d895f99dd53b ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/a746f7894ae96558abd0775aef68d895f99dd53b |
