Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2206813002: [chromecast] Remove default chromecast-wide deps. (Closed)

Created:
4 years, 4 months ago by alokp
Modified:
4 years, 4 months ago
Reviewers:
halliwell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Remove default chromecast-wide deps. TBR=avi,davidben,dalecurtis Committed: https://crrev.com/78e63b58f9b2709c5cb4e7246ced9be6e05ab38f Cr-Commit-Position: refs/heads/master@{#409453}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M chromecast/DEPS View 1 chunk +2 lines, -9 lines 0 comments Download
M chromecast/android/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/app/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/app/android/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/base/DEPS View 1 chunk +1 line, -5 lines 2 comments Download
M chromecast/browser/DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
M chromecast/browser/android/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + chromecast/common/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/graphics/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M chromecast/media/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/media/cma/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + chromecast/net/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
M chromecast/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/renderer/media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
alokp
4 years, 4 months ago (2016-08-02 23:51:59 UTC) #2
halliwell
lgtm % a question https://codereview.chromium.org/2206813002/diff/1/chromecast/base/DEPS File chromecast/base/DEPS (left): https://codereview.chromium.org/2206813002/diff/1/chromecast/base/DEPS#oldcode6 chromecast/base/DEPS:6: "-ui", why loosen these?
4 years, 4 months ago (2016-08-03 00:17:49 UTC) #5
alokp
TBR'ing DEPS owners as we are not adding any new dependencies. https://codereview.chromium.org/2206813002/diff/1/chromecast/base/DEPS File chromecast/base/DEPS (left): ...
4 years, 4 months ago (2016-08-03 04:21:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206813002/1
4 years, 4 months ago (2016-08-03 04:21:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 04:24:38 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 04:26:38 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/78e63b58f9b2709c5cb4e7246ced9be6e05ab38f
Cr-Commit-Position: refs/heads/master@{#409453}

Powered by Google App Engine
This is Rietveld 408576698