[api] Clean up scopes and precheck instantiations cache

[api] Clean up scopes and precheck instantiations cache

Make sure all the scopes used in api-natives.cc have inlineable constructors
and destructors. Additionally directly precheck the instantiations cache before
trying to enter the InvokeScope which sets the save_context.

BUG=chromium:630217
Committed: https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5
Cr-Commit-Position: refs/heads/master@{#38346}

[Camillo Bruni, 2016-08-03 09:09:24]

cbruni@chromium.org changed reviewers:
+ yangguo@dchromium.org

[Camillo Bruni, 2016-08-03 09:09:25]

PTAL

[Yang, 2016-08-04 11:39:28]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-08-04 11:39:28]

lgtm. with comments.

https://codereview.chromium.org/2206773003/diff/1/src/api-natives.cc
File src/api-natives.cc (right):

https://codereview.chromium.org/2206773003/diff/1/src/api-natives.cc#newcode518
src/api-natives.cc:518: return
::v8::internal::InstantiateFunctionWithInvokeScope(isolate, info);
do we really need to explicitly add the namespace here?

Also, why can't we just inline the function here?

[Camillo Bruni, 2016-08-04 12:15:16]

https://codereview.chromium.org/2206773003/diff/1/src/api-natives.cc
File src/api-natives.cc (right):

https://codereview.chromium.org/2206773003/diff/1/src/api-natives.cc#newcode518
src/api-natives.cc:518: return
::v8::internal::InstantiateFunctionWithInvokeScope(isolate, info);
On 2016/08/04 at 11:39:28, Yang wrote:
> do we really need to explicitly add the namespace here?
> 
> Also, why can't we just inline the function here?

oh the namespace is not needed, forgot to upload my latest version.
I want a separate function to avoid the InvokeScope to be stack-allocated.
clang is terrible with optimizing stack-allocated objects away, the only solid
trick is to have a separate function and make sure it doesn't get inlined.
In this case I'm less interested in the stack-allocation overhead rather than
the work done by the helper.

[Camillo Bruni, 2016-08-04 12:15:26]

cbruni@chromium.org changed reviewers:
- yangguo@dchromium.org

[Camillo Bruni, 2016-08-04 15:56:03]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-08-04 15:56:03]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2206773003/#ps20001
(title: "removing full namespace declaration")

[commit-bot: I haz the power, 2016-08-04 15:56:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 16:10:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 16:10:40]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Camillo Bruni, 2016-08-04 16:17:21]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-08-04 16:17:21]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2206773003/#ps40001
(title: "fixing omitted serial_number check")

[commit-bot: I haz the power, 2016-08-04 16:17:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 16:39:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-04 16:43:38]

Description was changed from

==========
[api] Clean up scopes and precheck instantiations cache

Make sure all the scopes used in api-natives.cc have inlineable constructors
and destructors. Additionally directly precheck the instantiations cache before
trying to enter the InvokeScope which sets the save_context.

BUG=chromium:630217
==========

to

==========
[api] Clean up scopes and precheck instantiations cache

Make sure all the scopes used in api-natives.cc have inlineable constructors
and destructors. Additionally directly precheck the instantiations cache before
trying to enter the InvokeScope which sets the save_context.

BUG=chromium:630217

Committed: https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5
Cr-Commit-Position: refs/heads/master@{#38346}
==========

[commit-bot: I haz the power, 2016-08-04 16:43:39]

Patchset 3 (id:??) landed as
https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5
Cr-Commit-Position: refs/heads/master@{#38346}

[Michael Achenbach, 2016-08-05 06:53:41]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2216903003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Leads to mac asan failures:
https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/7835.

[Camillo Bruni, 2016-09-23 12:22:51]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2366903003/ by cbruni@chromium.org.

The reason for reverting is: Regresses API see go/v8-startup-api.