Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2206763005: Move signed_certificate_timestamp_and_status from net to cert (Closed)

Created:
4 years, 4 months ago by Eran Messeri
Modified:
4 years, 4 months ago
Reviewers:
eroman, jam, meacer, estark
CC:
cbentzel+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, chromium-reviews, darin-cc_chromium.org, jam, Ryan Sleevi, rsleevi+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move signed_certificate_timestamp_and_status from net to cert This is to enable using SignedCertificateTimestampAndStatusList in CTVerifyResult (to replace the three lists of SCTs with a single one). BUG=634006 Committed: https://crrev.com/dec1c8a91cbefa9bfd7fcff2d8c9d1e8905ea158 Cr-Commit-Position: refs/heads/master@{#410332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -72 lines) Patch
M chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/resource_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/resource_response_info.h View 1 chunk +1 line, -1 line 0 comments Download
A + net/cert/signed_certificate_timestamp_and_status.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/cert/signed_certificate_timestamp_and_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D net/ssl/signed_certificate_timestamp_and_status.h View 1 chunk +0 lines, -38 lines 0 comments Download
D net/ssl/signed_certificate_timestamp_and_status.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M net/ssl/ssl_info.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (19 generated)
Eran Messeri
Roman, PTAL at this small CL without any functional changes, which is a step in ...
4 years, 4 months ago (2016-08-04 22:34:58 UTC) #3
eroman
lgtm
4 years, 4 months ago (2016-08-04 23:31:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206763005/1
4 years, 4 months ago (2016-08-05 00:03:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/231584)
4 years, 4 months ago (2016-08-05 00:09:57 UTC) #12
Eran Messeri
Thanks for the quick review, Eric! Emily, John, please take a look at this small ...
4 years, 4 months ago (2016-08-05 02:04:16 UTC) #15
jam
lgtm
4 years, 4 months ago (2016-08-05 15:54:21 UTC) #16
estark
lgtm
4 years, 4 months ago (2016-08-05 16:46:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206763005/1
4 years, 4 months ago (2016-08-05 18:06:10 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/232108)
4 years, 4 months ago (2016-08-05 18:13:01 UTC) #21
Eran Messeri
Mustafa, could you please review the change to content/common/resource_messages.h ? that's just an include change.
4 years, 4 months ago (2016-08-07 07:33:31 UTC) #23
meacer
content/common/resource_messages.h LGTM
4 years, 4 months ago (2016-08-07 21:36:50 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206763005/1
4 years, 4 months ago (2016-08-08 12:04:53 UTC) #30
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 12:08:32 UTC) #31
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 12:09:49 UTC) #33
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dec1c8a91cbefa9bfd7fcff2d8c9d1e8905ea158
Cr-Commit-Position: refs/heads/master@{#410332}

Powered by Google App Engine
This is Rietveld 408576698