components/safe_browsing_db/v4_database.cc - Issue 2206733002: PVer4: Verify checksum for downloaded updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_database.cc

Issue 2206733002: PVer4: Verify checksum for downloaded updates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_v4_rice_store

Patch Set: git pull Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/safe_browsing_db/v4_database.cc

diff --git a/components/safe_browsing_db/v4_database.cc b/components/safe_browsing_db/v4_database.cc

index 59bea71a173cbbe51756d6d8333a402e2c1ef61e..f341d121aa8e22256601e093e10af2cf72bed525 100644

--- a/components/safe_browsing_db/v4_database.cc

+++ b/components/safe_browsing_db/v4_database.cc

@@ -139,6 +139,8 @@ void V4Database::UpdatedStoreReady(UpdateListIdentifier identifier,

DCHECK(pending_store_updates_);

if (new_store) {

(*store_map_)[identifier] = std::move(new_store);

+ } else {

+ DVLOG(1) << "Store update discarded: " << *(*store_map_)[identifier];

Nathan Parker 2016/08/09 00:10:19 nit: I suspect this is redundant with the "ApplyUp

}

pending_store_updates_--;

« no previous file with comments | « components/safe_browsing_db/BUILD.gn ('k') | components/safe_browsing_db/v4_rice.cc » ('j') | components/safe_browsing_db/v4_store.cc » ('J')