PVer4: Verify checksum for downloaded updates

components/safe_browsing_db/v4_rice.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/numerics/safe_math.h"
 #include "base/strings/stringprintf.h"
 #include "components/safe_browsing_db/v4_rice.h"
 
 using ::google::protobuf::RepeatedField;
@@ skipping 245 matching lines @@
 }
 
 void V4RiceDecoder::GetBitsFromCurrentWord(unsigned int num_requested_bits,
                                            uint32_t* x) {
   uint32_t mask = 0xFFFFFFFF >> (kMaxBitIndex - num_requested_bits);
   *x = current_word_ & mask;
   current_word_ = current_word_ >> num_requested_bits;
   current_word_bit_index_ += num_requested_bits;
 };
 
 std::string V4RiceDecoder::DebugString() const {

[Nathan Parker, 2016/08/08 21:17:19]

Are there constants describing what 4 and 8 are?  It isn't clear to me what this
equation represents.

[vakh (use Gerrit instead), 2016/08/08 22:46:47]

Now using constants and added a comment describing that calculation.

+  unsigned bits_read = (data_byte_index_ - 4) * 8 + current_word_bit_index_;
   return base::StringPrintf(
-      "current_word_: %x; data_byte_index_; %x, "
+      "bits_read: %x; current_word_: %x; data_byte_index_; %x, "
       "current_word_bit_index_: %x; rice_parameter_: %x",
-      current_word_, data_byte_index_, current_word_bit_index_,
+      bits_read, current_word_, data_byte_index_, current_word_bit_index_,
       rice_parameter_);
 }
 
 std::ostream& operator<<(std::ostream& os, const V4RiceDecoder& rice_decoder) {
   os << rice_decoder.DebugString();
   return os;
 }
 
 }  // namespace safe_browsing