Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: test/intl/date-format/protected-icu-internals.js

Issue 220673002: Revert r20375. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/intl/collator/protected-icu-internals.js ('k') | test/intl/number-format/protected-icu-internals.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/intl/date-format/protected-icu-internals.js
diff --git a/test/mjsunit/regress/json-stringifier-emptyhandle.js b/test/intl/date-format/protected-icu-internals.js
similarity index 73%
copy from test/mjsunit/regress/json-stringifier-emptyhandle.js
copy to test/intl/date-format/protected-icu-internals.js
index 970b0b834cd47d5b480638d1a037e16de6d2b8a4..140f4b594d8a7d4d6f35734956d6d8e20ff9c06d 100644
--- a/test/mjsunit/regress/json-stringifier-emptyhandle.js
+++ b/test/intl/date-format/protected-icu-internals.js
@@ -25,20 +25,25 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+// Internal object we got from native code should not be writable,
+// configurable or enumerable. One can still change its public properties, but
+// we don't use them to do actual work.
-function explode() {
- var array = [1,2,3];
+var format = new Intl.DateTimeFormat([]);
- Object.defineProperty(array, 4, {
- get: function () { throw "dynamite"; },
- });
+// Direct write should fail.
+format.formatter = {'zzz':'some random object'};
- JSON.stringify(array);
-}
+assertFalse(format.formatter.hasOwnProperty('zzz'));
+// Try redefining the property.
+var didThrow = false;
try {
- explode();
- assertUnreachable();
+ Object.defineProperty(format, 'formatter', {value: undefined});
} catch(e) {
- assertEquals("dynamite", e);
+ didThrow = true;
}
+assertTrue(didThrow);
+
+// Try deleting the property.
+assertFalse(delete format.formatter);
« no previous file with comments | « test/intl/collator/protected-icu-internals.js ('k') | test/intl/number-format/protected-icu-internals.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698