chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h - Issue 2206693002: Improve settings override bubble to indicate policy installed extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h

Issue 2206693002: Improve settings override bubble to indicate policy installed extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase master Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm ('k') | chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm » ('j') | chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h

diff --git a/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h b/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h

index ffc67c1419a8b61e18f6f0f1a73e446d1a004257..deb3345673070b1353420951fc24a535005d1480 100644

--- a/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h

+++ b/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h

@@ -33,8 +33,14 @@ class ToolbarActionsBarBubbleDelegate;

// The dismiss button. Optional.

NSButton* dismissButton_;

- // The "learn more" link-style button. Optional.

- NSButton* learnMoreButton_;

+ // The extra view text as link-style button. Optional.

Devlin 2016/10/20 00:23:42 nit: need proper grammar in comments, so this shou

catmullings 2016/10/21 03:49:28 Done.

+ NSButton* link_;

+ // The extra view text as label. Optional.

+ NSTextField* label_;

+ // The extra view icon that can accompany the extra view text. Optional.

+ NSImageView* iconView_;

// This bubble's delegate.

std::unique_ptr<ToolbarActionsBarBubbleDelegate> delegate_;

@@ -53,7 +59,9 @@ class ToolbarActionsBarBubbleDelegate;

@property(readonly, nonatomic) NSButton* actionButton;

@property(readonly, nonatomic) NSTextField* itemList;

@property(readonly, nonatomic) NSButton* dismissButton;

-@property(readonly, nonatomic) NSButton* learnMoreButton;

+@property(readonly, nonatomic) NSButton* link;

+@property(readonly, nonatomic) NSTextField* label;

+@property(readonly, nonatomic) NSImageView* iconView;

@end