chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc - Issue 2206693002: Improve settings override bubble to indicate policy installed extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc

Issue 2206693002: Improve settings override bubble to indicate policy installed extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing tests ToolbarActionsBarBubbleViewsTest.TestClickLearnMoreLink and TestBubbleLayoutAct… Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/extensions/extension_message_bubble_bridge.cc ('K') | « chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h ('k') | chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h » ('j') | chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc

diff --git a/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc b/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc

index d71f71e42f6b71b58e93cd5636da5e9cd6c8b9e1..081a9917c182cc922de51ce54aa69f30155cab30 100644

--- a/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc

+++ b/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc

@@ -29,6 +29,12 @@ class TestToolbarActionsBarBubbleDelegate::DelegateImpl

base::string16 GetLearnMoreButtonText() override {

return parent_->learn_more_;

}

+ std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo>

+ GetExtraViewInfo() override {

+ std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo>

+ extra_view_info(new ExtraViewInfo(parent_->extra_view_info_));

+ return extra_view_info;

Devlin 2016/09/26 20:13:09 return base::MakeUnique<ExtraViewInfo>(...)

catmullings 2016/10/06 18:24:19 Done.

+ }

std::string GetAnchorActionId() override { return std::string(); }

void OnBubbleShown() override {

CHECK(!parent_->shown_);