Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h

Issue 2206693002: Improve settings override bubble to indicate policy installed extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed patch 3 code review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_
6 #define CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_ 6 #define CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
11 11
12 // A delegate for a generic bubble that hangs off the toolbar actions bar. 12 // A delegate for a generic bubble that hangs off the toolbar actions bar.
13 class ToolbarActionsBarBubbleDelegate { 13 class ToolbarActionsBarBubbleDelegate {
14 public: 14 public:
15 enum CloseAction { 15 enum CloseAction {
16 CLOSE_LEARN_MORE, 16 CLOSE_LEARN_MORE,
17 CLOSE_EXECUTE, 17 CLOSE_EXECUTE,
18 CLOSE_DISMISS_USER_ACTION, 18 CLOSE_DISMISS_USER_ACTION,
19 CLOSE_DISMISS_DEACTIVATION, 19 CLOSE_DISMISS_DEACTIVATION,
20 }; 20 };
21 21
22 // Content populating an optional view, containing an image icon and/or
23 // (linked) text, in the bubble.
24 struct ExtraViewInfo {
25 // The resource id referencing the image icon. If has a value of -1, then no
26 // image icon will be added.
27 int resource_id = -1;
28 // Text in the view. If this is an empty string, no text will be added.
29 base::string16 text;
30 // If the struct's text is nonempty and this value is true, then a link of
31 // the text is added. If this value is false, the text is not treated as a
32 // link.
33 bool is_text_linked;
34 ExtraViewInfo() : resource_id(-1) {}
Devlin 2016/09/07 18:37:49 nits: ctors before members, and this should be def
catmullings 2016/09/08 15:42:29 Done.
catmullings 2016/09/08 15:42:29 Leaving ctor here b/c there is no accompanying .cc
35 };
36
22 virtual ~ToolbarActionsBarBubbleDelegate() {} 37 virtual ~ToolbarActionsBarBubbleDelegate() {}
23 38
24 // Returns true if the bubble should (still) be shown. Since bubbles are 39 // Returns true if the bubble should (still) be shown. Since bubbles are
25 // sometimes shown asynchronously, they may be invalid by the time they would 40 // sometimes shown asynchronously, they may be invalid by the time they would
26 // be displayed. 41 // be displayed.
27 virtual bool ShouldShow() = 0; 42 virtual bool ShouldShow() = 0;
28 43
29 // Returns true if the bubble should close on deactivation. 44 // Returns true if the bubble should close on deactivation.
30 virtual bool ShouldCloseOnDeactivate() = 0; 45 virtual bool ShouldCloseOnDeactivate() = 0;
31 46
(...skipping 25 matching lines...) Expand all
57 72
58 // Returns the id of the action to point to, or the empty string if the 73 // Returns the id of the action to point to, or the empty string if the
59 // bubble should point to the center of the actions container. 74 // bubble should point to the center of the actions container.
60 virtual std::string GetAnchorActionId() = 0; 75 virtual std::string GetAnchorActionId() = 0;
61 76
62 // Called when the bubble is shown. 77 // Called when the bubble is shown.
63 virtual void OnBubbleShown() = 0; 78 virtual void OnBubbleShown() = 0;
64 79
65 // Called when the bubble is closed with the type of action the user took. 80 // Called when the bubble is closed with the type of action the user took.
66 virtual void OnBubbleClosed(CloseAction action) = 0; 81 virtual void OnBubbleClosed(CloseAction action) = 0;
82
83 // Returns the ExtraViewInfo struct associated with the bubble delegate. If
84 // this returns a nullptr, no extra view (image icon and/or (linked) text) is
85 // added to the bubble.
86 virtual std::unique_ptr<ExtraViewInfo> GetExtraViewInfo() = 0;
67 }; 87 };
68 88
69 #endif // CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_ 89 #endif // CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_BUBBLE_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698