Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 2206683002: GN: re-run echo_headers if git state changes. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: re-run echo_headers if git state changes. This should mean it re-runs if a header is added or removed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206683002 Committed: https://skia.googlesource.com/skia/+/372913f9328b6350e400bd2d1f8afae51c095a2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 4 months ago (2016-08-02 19:41:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206683002/1
4 years, 4 months ago (2016-08-02 19:41:08 UTC) #5
jcgregorio
lgtm
4 years, 4 months ago (2016-08-02 19:41:17 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 20:05:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/372913f9328b6350e400bd2d1f8afae51c095a2c

Powered by Google App Engine
This is Rietveld 408576698