Change V8CacheOnCacheStorage tests to wait for the V8 code cache to be written.

Change V8CacheOnCacheStorage tests to wait for the V8 code cache to be written.

To fix the flakiess:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=V8CacheOnCacheStorage

BUG=625018
Committed: https://crrev.com/3764ce47659fc1825476abe6139f02dd4e8b1e70
Cr-Commit-Position: refs/heads/master@{#410298}

[horo, 2016-08-03 05:40:55]

Patchset #1 (id:1) has been deleted

[horo, 2016-08-03 05:42:51]

horo@chromium.org changed reviewers:
+ shimazu@chromium.org

[horo, 2016-08-03 05:42:51]

shimazu@
Could you please review this?

[shimazu, 2016-08-03 06:06:54]

https://codereview.chromium.org/2206673003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/2206673003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_browsertest.cc:1865: while (true)
{
I feel better to have timeout not to get stuck in infinite loop situation. What
do you think?

[horo, 2016-08-03 10:33:26]

https://codereview.chromium.org/2206673003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/2206673003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_browsertest.cc:1865: while (true)
{
On 2016/08/03 06:06:54, shimazu wrote:
> I feel better to have timeout not to get stuck in infinite loop situation.
What
> do you think?

The testing framework has its own timeout logic (base/test/test_timeouts.h).
So I think we should not implement here.
For example, TitleWatcher doesn't have a timeout logic.

[horo, 2016-08-04 02:28:12]

Description was changed from

==========
Change V8CacheOnCacheStorage tests to wait for the V8 code cache to be written.


BUG=625018
==========

to

==========
Change V8CacheOnCacheStorage tests to wait for the V8 code cache to be written.

To fix the flakiess:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

BUG=625018
==========

[shimazu, 2016-08-08 02:30:45]

sorry for my late reply! lgtm:)

https://codereview.chromium.org/2206673003/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/2206673003/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_browsertest.cc:1865: while (true)
{
On 2016/08/03 10:33:26, horo wrote:
> On 2016/08/03 06:06:54, shimazu wrote:
> > I feel better to have timeout not to get stuck in infinite loop situation.
> What
> > do you think?
> 
> The testing framework has its own timeout logic (base/test/test_timeouts.h).
> So I think we should not implement here.
> For example, TitleWatcher doesn't have a timeout logic.

I see, thanks!

[horo, 2016-08-08 02:55:28]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-08-08 02:55:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 04:13:33]

Description was changed from

==========
Change V8CacheOnCacheStorage tests to wait for the V8 code cache to be written.

To fix the flakiess:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

BUG=625018
==========

to

==========
Change V8CacheOnCacheStorage tests to wait for the V8 code cache to be written.

To fix the flakiess:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

BUG=625018
==========

[commit-bot: I haz the power, 2016-08-08 04:13:34]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-08-08 04:15:48]

Description was changed from

==========
Change V8CacheOnCacheStorage tests to wait for the V8 code cache to be written.

To fix the flakiess:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

BUG=625018
==========

to

==========
Change V8CacheOnCacheStorage tests to wait for the V8 code cache to be written.

To fix the flakiess:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

BUG=625018

Committed: https://crrev.com/3764ce47659fc1825476abe6139f02dd4e8b1e70
Cr-Commit-Position: refs/heads/master@{#410298}
==========

[commit-bot: I haz the power, 2016-08-08 04:15:49]

Patchset 1 (id:??) landed as
https://crrev.com/3764ce47659fc1825476abe6139f02dd4e8b1e70
Cr-Commit-Position: refs/heads/master@{#410298}