tools/get_images_from_skps.cpp - Issue 2206633004: Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/get_images_from_skps.cpp

Issue 2206633004: Move off SK_SUPPORT_LEGACY_DATA_FACTORIES. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Gotta catch 'em all. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/get_images_from_skps.cpp

diff --git a/tools/get_images_from_skps.cpp b/tools/get_images_from_skps.cpp

index 11b99c214d1f9b5ea3753057033603ae23d60807..f9ba34b0f26f69b59bf1c4640dd9d3501a8e5c67 100644

--- a/tools/get_images_from_skps.cpp

+++ b/tools/get_images_from_skps.cpp

@@ -53,8 +53,8 @@ struct Sniffer : public SkPixelSerializer {

}

gSeen.add(digest);

- SkAutoTUnref<SkData> data(SkData::NewWithoutCopy(ptr, len));

- SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(data));

+ sk_sp<SkData> data(SkData::MakeWithoutCopy(ptr, len));

+ SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(data.get()));

if (!codec) {

// FIXME: This code is currently unreachable because we create an empty generator when

// we fail to create a codec.