Set UNbufferIO env for Earlgrey tests outputs.

Set UNbufferIO env for Earlgrey tests outputs.

The test outputs are sometimes out of order due to the buffer thing.
"** TEST SUCCEEDED **" is printed out randomly.  UnBuffer to avoid
this.

BUG=632190
Committed: https://chromium.googlesource.com/chromium/tools/build/+/cc1d77c36468f1393c7c538b33717b42ac940a0d

[huangml1, 2016-08-02 18:51:20]

huangml@chromium.org changed reviewers:
+ huangml@chromium.org, smut@google.com

[huangml1, 2016-08-02 18:51:21]

There are some false positive test fails on the bots due to some random outputs.
 PTAL, thanks.

[smut, 2016-08-02 23:21:21]

The CQ bit was checked by smut@google.com

[smut, 2016-08-02 23:21:22]

lgtm

[commit-bot: I haz the power, 2016-08-02 23:21:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 23:25:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 23:25:24]

Failed to apply patch for scripts/slave/ios/test_runner.py:
While running git apply --index -3 -p1;
  error: patch failed: scripts/slave/ios/test_runner.py:1251
  Falling back to three-way merge...
  Applied patch to 'scripts/slave/ios/test_runner.py' with conflicts.
  U scripts/slave/ios/test_runner.py

Patch:       scripts/slave/ios/test_runner.py
Index: scripts/slave/ios/test_runner.py
diff --git a/scripts/slave/ios/test_runner.py b/scripts/slave/ios/test_runner.py
index
94799812319a5e182034a8c09ed7755ca02c9cd7..5c3f46ebf37702a877c9fdc9172023bac3b46d55
100755
--- a/scripts/slave/ios/test_runner.py
+++ b/scripts/slave/ios/test_runner.py
@@ -846,7 +846,8 @@ class XCTestRunner(TestRunner):
     """Returns the environment which is used to run the xctest.
     """
     env = dict(os.environ, APP_TARGET_NAME=self.test_host_name,
-               TEST_TARGET_NAME=self.test_target_name)
+               TEST_TARGET_NAME=self.test_target_name,
+               NSUnbufferedIO='YES')
     return env
 
   def GetLaunchCommand(self, test_filter=None, blacklist=False):
@@ -1251,15 +1252,18 @@ class SimulatorXCTestRunner(XCTestRunner):
     """
     built_dir = os.path.split(self.app_path)[0]
 
-    cmd =['xcodebuild', 'test',
-          'BUILT_PRODUCTS_DIR=%s' % built_dir,
-          '-project', self.test_project_dir,
-          '-scheme','TestProject',
-          '-destination','platform=iOS Simulator,name=%s,OS=%s'
-          % (self.platform, self.version),
-          '-archivePath', self.homedir,
-          'APP_TARGET_NAME=%s' % self.test_host_name,
-          'TEST_TARGET_NAME=%s' % self.test_target_name]
+    cmd = [
+      'xcodebuild', 'test',
+      'BUILT_PRODUCTS_DIR=%s' % built_dir,
+      '-project', self.test_project_dir,
+      '-scheme','TestProject',
+      '-destination','platform=iOS Simulator,name=%s,OS=%s'
+      % (self.platform, self.version),
+      '-archivePath', self.homedir,
+      'APP_TARGET_NAME=%s' % self.test_host_name,
+      'TEST_TARGET_NAME=%s' % self.test_target_name,
+      'NSUnbufferedIO=YES'
+    ]
     return cmd
 
   @TestRunner.RequireTearDown
@@ -1406,15 +1410,18 @@ class DeviceXCTestRunner(XCTestRunner):
     """
     built_dir = os.path.split(self.app_path)[0]
 
-    cmd =['xcodebuild', 'test',
-          'BUILT_PRODUCTS_DIR=%s' % built_dir,
-          'CONFIGURATION_BUILD_DIR=%s' % built_dir,
-          '-project', self.test_project_dir,
-          '-configuration', 'iphoneos',
-          '-scheme', 'TestProject',
-          '-destination','id=%s' % self.device_id,
-          'APP_TARGET_NAME=%s' % self.test_host_name,
-          'TEST_TARGET_NAME=%s' % self.test_target_name]
+    cmd = [
+      'xcodebuild', 'test-without-building',
+      'BUILT_PRODUCTS_DIR=%s' % built_dir,
+      'CONFIGURATION_BUILD_DIR=%s' % built_dir,
+      '-project', self.test_project_dir,
+      '-configuration', 'iphoneos',
+      '-scheme', 'TestProject',
+      '-destination','id=%s' % self.device_id,
+      'APP_TARGET_NAME=%s' % self.test_host_name,
+      'TEST_TARGET_NAME=%s' % self.test_target_name,
+      'NSUnbufferedIO=YES'
+    ]
     return cmd
 
   @TestRunner.RequireTearDown

[huangml1, 2016-08-03 00:29:02]

The CQ bit was checked by huangml@chromium.org

[huangml1, 2016-08-03 00:29:03]

The patchset sent to the CQ was uploaded after l-g-t-m from smut@google.com
Link to the patchset: https://codereview.chromium.org/2206633002/#ps20001
(title: "Merge branch 'master' of
https://chromium.googlesource.com/chromium/tools/build into crash")

[commit-bot: I haz the power, 2016-08-03 00:29:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 00:33:04]

Description was changed from

==========
Set UNbufferIO env for Earlgrey tests outputs.

The test outputs are sometimes out of order due to the buffer thing.
"** TEST SUCCEEDED **" is printed out randomly.  UnBuffer to avoid
this.

BUG=632190
==========

to

==========
Set UNbufferIO env for Earlgrey tests outputs.

The test outputs are sometimes out of order due to the buffer thing.
"** TEST SUCCEEDED **" is printed out randomly.  UnBuffer to avoid
this.

BUG=632190

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/cc1d77c36468f1393c7c...
==========

[commit-bot: I haz the power, 2016-08-03 00:33:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/cc1d77c36468f1393c7c...