Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2206583007: Handle the case when the updates are disabled for a component. (Closed)

Created:
4 years, 4 months ago by Sorin Jianu
Modified:
4 years, 4 months ago
Reviewers:
waffles
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle the case when the updates are disabled for a component. This change does not include the group policy changes. BUG=624128 Committed: https://crrev.com/e84ff700af9117c3be17a74d90b04be03dc4a689 Cr-Commit-Position: refs/heads/master@{#409693}

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -16 lines) Patch
M components/update_client/action.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/update_client/action.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M components/update_client/test_configurator.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/update_client/test_configurator.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M components/update_client/update_checker.cc View 1 1 chunk +10 lines, -4 lines 0 comments Download
M components/update_client/update_checker_unittest.cc View 1 5 chunks +84 lines, -4 lines 0 comments Download
M components/update_client/update_client_unittest.cc View 3 chunks +243 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
waffles
lgtm modulo quoting issue https://codereview.chromium.org/2206583007/diff/1/components/update_client/update_checker.cc File components/update_client/update_checker.cc (right): https://codereview.chromium.org/2206583007/diff/1/components/update_client/update_checker.cc#newcode98 components/update_client/update_checker.cc:98: base::StringAppendF(&app, " \"updatedisabled\"=true"); I think ...
4 years, 4 months ago (2016-08-03 23:49:02 UTC) #5
Sorin Jianu
done, ty!
4 years, 4 months ago (2016-08-04 00:12:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206583007/20001
4 years, 4 months ago (2016-08-04 00:13:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 01:22:19 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 01:25:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e84ff700af9117c3be17a74d90b04be03dc4a689
Cr-Commit-Position: refs/heads/master@{#409693}

Powered by Google App Engine
This is Rietveld 408576698