Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2206583004: PPC: set kMinimumCodeRangeSize in test-spaces/Regress3540 as multiple of PageSize (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: set kMinimumCodeRangeSize in test-spaces/Regress3540 as multiple of PageSize Setting kMinimumCodeRangeSize as 3*pagesize. This will set the constant correctly for PPC where pagesize is 4MB. R=mlippautz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/5fc50a91c304e4933313bba97635747ff167136b Cr-Commit-Position: refs/heads/master@{#38450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/heap/test-spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 4 months ago (2016-08-03 16:46:08 UTC) #1
Michael Lippautz
lgtm
4 years, 4 months ago (2016-08-08 15:28:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206583004/1
4 years, 4 months ago (2016-08-08 15:31:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 15:56:31 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 15:56:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fc50a91c304e4933313bba97635747ff167136b
Cr-Commit-Position: refs/heads/master@{#38450}

Powered by Google App Engine
This is Rietveld 408576698