Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2206573004: Revert of [inspector] include additional outputs from protocol handler generator. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] include additional outputs from protocol handler generator. (patchset #2 id:20001 of https://codereview.chromium.org/2199253002/ ) Reason for revert: Compile warnings: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/1901/steps/compile/logs/stdio Original issue's description: > [inspector] include additional outputs from protocol handler generator. > > The protocol handler generator generates these files into a default location if > not specified by flag as output. We should account for these files and > explicitly set its output location. > > R=machenbach@chromium.org > > Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 > Cr-Commit-Position: refs/heads/master@{#38268} TBR=machenbach@chromium.org,faith4roy16@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/dfcaaeb720a982079aab36bed0b6b83995a0ad86 Cr-Commit-Position: refs/heads/master@{#38272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -33 lines) Patch
M src/inspector/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M src/inspector/inspector.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/inspector/js_protocol.json View 7 chunks +2 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yang
Created Revert of [inspector] include additional outputs from protocol handler generator.
4 years, 4 months ago (2016-08-03 06:34:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206573004/1
4 years, 4 months ago (2016-08-03 06:34:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 06:34:25 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 06:35:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfcaaeb720a982079aab36bed0b6b83995a0ad86
Cr-Commit-Position: refs/heads/master@{#38272}

Powered by Google App Engine
This is Rietveld 408576698