Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: src/api.cc

Issue 2206573002: Move NoSideEffectToString to C++ (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 2e82e05c99dfbd9a5b6e684b64dc6421f968dd0c..d56fbf22ca69ce83dc7bb23f0cc274988f5ca122 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -3092,13 +3092,8 @@ MaybeLocal<String> Value::ToDetailString(Local<Context> context) const {
i::Handle<i::Object> obj = Utils::OpenHandle(this);
if (obj->IsString()) return ToApiHandle<String>(obj);
PREPARE_FOR_EXECUTION(context, Object, ToDetailString, String);
- Local<String> result;
- i::Handle<i::Object> args[] = {obj};
- has_pending_exception = !ToLocal<String>(
- i::Execution::TryCall(isolate, isolate->no_side_effects_to_string_fun(),
- isolate->factory()->undefined_value(),
- arraysize(args), args),
- &result);
+ Local<String> result =
+ Utils::ToLocal(i::Object::NoSideEffectsToString(isolate, obj));
RETURN_ON_FAILED_EXECUTION(String);
RETURN_ESCAPED(result);
}
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698