Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: src/runtime/runtime-internal.cc

Issue 2206573002: Move NoSideEffectToString to C++ (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | test/cctest/cctest.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/ast/prettyprinter.h" 10 #include "src/ast/prettyprinter.h"
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 377
378 378
379 RUNTIME_FUNCTION(Runtime_MessageGetScript) { 379 RUNTIME_FUNCTION(Runtime_MessageGetScript) {
380 SealHandleScope shs(isolate); 380 SealHandleScope shs(isolate);
381 DCHECK(args.length() == 1); 381 DCHECK(args.length() == 1);
382 CONVERT_ARG_CHECKED(JSMessageObject, message, 0); 382 CONVERT_ARG_CHECKED(JSMessageObject, message, 0);
383 return message->script(); 383 return message->script();
384 } 384 }
385 385
386 386
387 RUNTIME_FUNCTION(Runtime_FormatMessageString) {
388 HandleScope scope(isolate);
389 DCHECK(args.length() == 4);
390 CONVERT_INT32_ARG_CHECKED(template_index, 0);
391 CONVERT_ARG_HANDLE_CHECKED(String, arg0, 1);
392 CONVERT_ARG_HANDLE_CHECKED(String, arg1, 2);
393 CONVERT_ARG_HANDLE_CHECKED(String, arg2, 3);
394 isolate->native_context()->IncrementErrorsThrown();
395 RETURN_RESULT_OR_FAILURE(isolate, MessageTemplate::FormatMessage(
396 template_index, arg0, arg1, arg2));
397 }
398
399
400 RUNTIME_FUNCTION(Runtime_IS_VAR) { 387 RUNTIME_FUNCTION(Runtime_IS_VAR) {
401 UNREACHABLE(); // implemented as macro in the parser 388 UNREACHABLE(); // implemented as macro in the parser
402 return NULL; 389 return NULL;
403 } 390 }
404 391
405 392
406 namespace { 393 namespace {
407 394
408 bool ComputeLocation(Isolate* isolate, MessageLocation* target) { 395 bool ComputeLocation(Isolate* isolate, MessageLocation* target) {
409 JavaScriptFrameIterator it(isolate); 396 JavaScriptFrameIterator it(isolate);
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 574
588 RUNTIME_FUNCTION(Runtime_Typeof) { 575 RUNTIME_FUNCTION(Runtime_Typeof) {
589 HandleScope scope(isolate); 576 HandleScope scope(isolate);
590 DCHECK_EQ(1, args.length()); 577 DCHECK_EQ(1, args.length());
591 CONVERT_ARG_HANDLE_CHECKED(Object, object, 0); 578 CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);
592 return *Object::TypeOf(isolate, object); 579 return *Object::TypeOf(isolate, object);
593 } 580 }
594 581
595 } // namespace internal 582 } // namespace internal
596 } // namespace v8 583 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime.h ('k') | test/cctest/cctest.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698