Move NoSideEffectToString to C++

src/builtins/builtins-error.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 
 #include "src/messages.h"
 #include "src/property-descriptor.h"
 #include "src/string-builder.h"
 
 namespace v8 {
 namespace internal {
 
 // ES6 section 19.5.1.1 Error ( message )
 BUILTIN(ErrorConstructor) {
   HandleScope scope(isolate);
+
+  FrameSkipMode mode = SKIP_FIRST;
+  Handle<Object> caller;
+
+  // When we're passed a JSFunction as new target, we can skip frames until that
+  // specific function is seen instead of unconditionally skipping the first
+  // frame.
+  if (args.new_target()->IsJSFunction()) {
+    mode = SKIP_UNTIL_SEEN;
+    caller = args.new_target();
+  }
+
   RETURN_RESULT_OR_FAILURE(
-      isolate,
-      ErrorUtils::Construct(isolate, args.target<JSFunction>(),
-                            Handle<Object>::cast(args.new_target()),
-                            args.atOrUndefined(isolate, 1), SKIP_FIRST, false));
+      isolate, ErrorUtils::Construct(isolate, args.target<JSFunction>(),
+                                     Handle<Object>::cast(args.new_target()),
+                                     args.atOrUndefined(isolate, 1), mode,
+                                     caller, false));
 }
 
 // static
 BUILTIN(ErrorCaptureStackTrace) {
   HandleScope scope(isolate);
   Handle<Object> object_obj = args.atOrUndefined(isolate, 1);
   if (!object_obj->IsJSObject()) {
     THROW_NEW_ERROR_RETURN_FAILURE(
         isolate, NewTypeError(MessageTemplate::kInvalidArgument, object_obj));
   }
@@ skipping 29 matching lines @@
   return isolate->heap()->undefined_value();
 }
 
 // ES6 section 19.5.3.4 Error.prototype.toString ( )
 BUILTIN(ErrorPrototypeToString) {
   HandleScope scope(isolate);
   RETURN_RESULT_OR_FAILURE(isolate,
                            ErrorUtils::ToString(isolate, args.receiver()));
 }
 
+BUILTIN(MakeGenericError) {
+  HandleScope scope(isolate);
+
+  Handle<Object> constructor = args.atOrUndefined(isolate, 1);
+  Handle<Object> template_index = args.atOrUndefined(isolate, 2);
+  Handle<Object> arg0 = args.atOrUndefined(isolate, 3);
+  Handle<Object> arg1 = args.atOrUndefined(isolate, 4);
+  Handle<Object> arg2 = args.atOrUndefined(isolate, 5);
+
+  DCHECK(constructor->IsJSFunction());
+  DCHECK(template_index->IsSmi());
+
+  RETURN_RESULT_OR_FAILURE(
+      isolate,
+      ErrorUtils::MakeGenericError(
+          isolate, Handle<JSFunction>::cast(constructor),
+          Smi::cast(*template_index)->value(), arg0, arg1, arg2, SKIP_FIRST));
+}
+
 }  // namespace internal
 }  // namespace v8