Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2206553002: [turbofan] Fix invalid representation selection for Phis/Selects. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix invalid representation selection for Phis/Selects. We cannot just blindly make a representation selection for Phi or Select based on the truncations, but we also need to consider the type of the inputs (or actually of the Phi/Select node itself). We can only use Word32 representation based on Word32 truncation if the inputs are Number or Oddball, same for Float64. R=epertoso@chromium.org BUG=v8:5255 Committed: https://crrev.com/c9324fe6c555ec12cef534d60f6b44d51cc9d961 Cr-Commit-Position: refs/heads/master@{#38241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-v8-5255-1.js View 1 chunk +4 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-v8-5255-2.js View 1 chunk +4 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-v8-5255-3.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-02 11:32:50 UTC) #1
epertoso
lgtm
4 years, 4 months ago (2016-08-02 12:04:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206553002/1
4 years, 4 months ago (2016-08-02 12:08:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 12:10:04 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 12:11:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9324fe6c555ec12cef534d60f6b44d51cc9d961
Cr-Commit-Position: refs/heads/master@{#38241}

Powered by Google App Engine
This is Rietveld 408576698