third_party/WebKit/Source/modules/mediastream/UserMediaClient.h - Issue 2206533003: Refactor lifetime management of UserMediaController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/UserMediaClient.h

Issue 2206533003: Refactor lifetime management of UserMediaController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/mediastream/UserMediaController.h » ('j') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/UserMediaClient.h

diff --git a/third_party/WebKit/Source/modules/mediastream/UserMediaClient.h b/third_party/WebKit/Source/modules/mediastream/UserMediaClient.h

index 4784c7518672a2433c2967f2f446f3f9373f1eb4..be2905ec4156af55cf5ae24f840b8a55285addf9 100644

--- a/third_party/WebKit/Source/modules/mediastream/UserMediaClient.h

+++ b/third_party/WebKit/Source/modules/mediastream/UserMediaClient.h

@@ -51,12 +51,10 @@ public:

virtual void cancelMediaDevicesRequest(MediaDevicesRequest*) = 0;

virtual void requestSources(MediaStreamTrackSourcesRequest*) = 0;

virtual void setMediaDeviceChangeObserver(MediaDevices*) = 0;

-protected:

virtual ~UserMediaClient() { }

};

-MODULES_EXPORT void provideUserMediaTo(LocalFrame&, UserMediaClient*);

+MODULES_EXPORT void provideUserMediaTo(LocalFrame&, std::unique_ptr<UserMediaClient>);

} // namespace blink

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/mediastream/UserMediaController.h » ('j') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('J')