Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/android/webapk/shell_apk/BUILD.gn

Issue 2206493002: Update WebAPK if homescreen icon changed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_updater_images2 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/shell_apk/BUILD.gn
diff --git a/chrome/android/webapk/shell_apk/BUILD.gn b/chrome/android/webapk/shell_apk/BUILD.gn
index 8605a80dd01ca0f13e691cfeda896fa1136010ab..c57266279a220127177eedf99858b59063a6f7c4 100644
--- a/chrome/android/webapk/shell_apk/BUILD.gn
+++ b/chrome/android/webapk/shell_apk/BUILD.gn
@@ -28,6 +28,11 @@ declare_args() {
# The URL of the app icon. Empty if the app icon is generated.
webapk_icon_url = "http://www.template.com/icon.png"
+ # Murmur2 hash of the homescreen icon. The hash should be of the icon as it is
+ # available from the web. The icon bytes should not be transformed (e.g.
+ # decoding / encoding) prior to taking the hash.
+ webapk_icon_murmur2_hash = "0L"
+
# Host part of |webapk_scope_url|.
webapk_scope_url_host = "www.template.com"
}
@@ -53,6 +58,7 @@ jinja_template("shell_apk_manifest") {
"theme_color=$webapk_theme_color",
"background_color=$webapk_background_color",
"icon_url=$webapk_icon_url",
+ "icon_murmur2_hash=$webapk_icon_murmur2_hash",
"scope_url_host=$webapk_scope_url_host",
"web_manifest_url=$webapk_web_manifest_url",
]

Powered by Google App Engine
This is Rietveld 408576698