Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2206463002: Revert of Prevent duplicate content script injection defined in manifest.json (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 4 months ago
Reviewers:
catmullings
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prevent duplicate content script injection defined in manifest.json (patchset #9 id:160001 of https://codereview.chromium.org/2116613002/ ) Reason for revert: Causes a renderer crash - http://crbug.com/631247 Original issue's description: > Keeps track of scripts injected by extensions installed. Checks if a script is > already injected, and injects a script only if it has not been injected. > > BUG=248627 > TEST= Run target browser_tests with > --gtest_filter="ExtensionApiTest.ContentScript*" > > Committed: https://crrev.com/90d8dd145246616da02f5a54f1da1f5bfe6680e9 > Cr-Commit-Position: refs/heads/master@{#407016} TBR=catmullings@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=248627 Committed: https://crrev.com/f05678d76cdf2f63b19e6716220ec1e951675856 Cr-Commit-Position: refs/heads/master@{#409109}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
Devlin
Created Revert of Prevent duplicate content script injection defined in manifest.json
4 years, 4 months ago (2016-08-02 00:13:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206463002/1
4 years, 4 months ago (2016-08-02 00:13:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 01:12:01 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 01:16:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f05678d76cdf2f63b19e6716220ec1e951675856
Cr-Commit-Position: refs/heads/master@{#409109}

Powered by Google App Engine
This is Rietveld 408576698