Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2206403002:
Fix octane test content URL (Closed)
DescriptionFix octane test content URL
Octane hostname changed to http://chromium.github.io/octane
hence fix test URLs
BUG=634067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/06d7d32a808579e2084c9bba65e217679c500f28
Cr-Commit-Position: refs/heads/master@{#410241}
Patch Set 1 #Patch Set 2 : Fix octane test URL and update WPR #
Total comments: 1
Patch Set 3 : Fix octane test URL and update WPR content #
Messages
Total messages: 45 (22 generated)
Description was changed from ========== Fix octane test content URL Octane hostname changed to http://chromium.github.io/octane hence fix test URLs BUG=634067 ========== to ========== Fix octane test content URL Octane hostname changed to http://chromium.github.io/octane hence fix test URLs BUG=634067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Fix octane test content URL Octane hostname changed to http://chromium.github.io/octane hence fix test URLs BUG=634067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Fix octane test content URL Octane hostname changed to http://chromium.github.io/octane hence fix test URLs BUG=634067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
sbonda@nvidia.com changed reviewers: + dtu@chromium.org, kbr@chromium.org, ulan@chromium.org
The CQ bit was checked by sbonda@nvidia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
I'm not an OWNER in this directory.
kbr@chromium.org changed reviewers: + aiolos@chromium.org, nednguyen@google.com - kbr@chromium.org
kbr@chromium.org changed reviewers: + kbr@chromium.org
kbr@chromium.org changed reviewers: - kbr@chromium.org
You also need to rerecord the benchmark
On 2016/08/03 20:09:44, nednguyen wrote: > You also need to rerecord the benchmark I am getting "Access Denied" issue even after login to google cloud storage. Does outside google engineers have access to upload new wpr files. $ python ~/depot_tools/upload_to_google_storage.py --bucket chromium-telemetry octane_002.wpr Main> Calculating hash for octane_002.wpr... Main> Done calculating hash for octane_002.wpr. 0> Uploading octane_002.wpr... Hashing 1 files took 0.004208 seconds Uploading took 152.115329 seconds Encountered error on uploading octane_002.wpr to gs://chromium-telemetry/be500a76f06992f058eb19a53a4dfdf6e3840730 Copying file://octane_002.wpr [Content-Type=application/octet-stream]... Uploading ...lemetry/be500a76f06992f058eb19a53a4dfdf6e3840730: 2.38 MiB/2.38 MiB AccessDeniedException: 403 Forbidden
I followed the instructions from https://sites.google.com/a/chromium.org/dev/developers/telemetry/upload_to_cl.... Am i missing anything else?
On 2016/08/03 21:14:28, Srikumar wrote: > I followed the instructions from > https://sites.google.com/a/chromium.org/dev/developers/telemetry/upload_to_cl.... > Am i missing anything else? Yeah, only Googlers have write access to the wpr files. You can upload the wpr files to google drive or dropbox & give us the link, we will land the patch with wpr change on your behalf. Thanks a lot for working on this!
Thanks for the reply nednguyen. I have shared the WPR content at https://drive.google.com/file/d/0B7PCTePSbIVAU0s1XzFEN3lueHM/view and attached the new patch with SHA id and updated json file in the bug 634067. I have locally tested the WPR content by running telemetry test and made sure it is working as expected. Please kindly review and land it. I tried to upload new patch to this CL itself but getting failures from presubmit upload checks: "catapult_base.cloud_storage.PermissionError: Attempted to access a file from Cloud Storage but you don't have permission.". Thanks again.
New patch is attached to bug#634067
On 2016/08/04 18:32:18, Srikumar wrote:
> New patch is attached to bug#634067
I uploaded your WPR content to the telemetry-chromium bucket, you should be able
to land this CL by apply this:
diff --git a/tools/perf/page_sets/data/octane.json
b/tools/perf/page_sets/data/octane.json
index 79c9786..44c0edb 100644
--- a/tools/perf/page_sets/data/octane.json
+++ b/tools/perf/page_sets/data/octane.json
@@ -1,8 +1,8 @@
{
- "description": "Describes the Web Page Replay archives for a page set.
Don't edit by hand! Use record_wpr for updating.",
+ "description": "Describes the Web Page Replay archives for a page set.
Don't edit by hand! Use record_wpr for updating.",
"archives": {
- "octane_001.wpr": [
-
"http://octane-benchmark.googlecode.com/svn/latest/index.html?auto=1"
+ "octane_002.wpr": [
+ "http://chromium.github.io/octane/index.html?auto=1"
]
}
-}
\ No newline at end of file
+}
diff --git a/tools/perf/page_sets/data/octane_002.wpr.sha1
b/tools/perf/page_sets/data/octane_002.wpr.sha1
new file mode 100644
index 0000000..92d99fb
--- /dev/null
+++ b/tools/perf/page_sets/data/octane_002.wpr.sha1
@@ -0,0 +1 @@
+be500a76f06992f058eb19a53a4dfdf6e3840730
\ No newline at end of file
Thanks alot nednguyen. I have uploaded new patch that contain *auto-generated* octane.json and octane_002.wpr.sha1 I did not manually modified anything on those files. Please review.
lgtm
The CQ bit was checked by sbonda@nvidia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
nednguyen, Looks like you removed octane_001.wpr from the server hence fetch test is failing to get octane_001.wpr I will fix the patch to refer all tests points to _002.war and delete existing references of octane_001 wpr content. Please wait for my next patch.
https://codereview.chromium.org/2206403002/diff/20001/tools/perf/page_sets/da... File tools/perf/page_sets/data/octane.json (right): https://codereview.chromium.org/2206403002/diff/20001/tools/perf/page_sets/da... tools/perf/page_sets/data/octane.json:3: "octane_001.wpr": [ You can just remove this one
Yaa, But i need to fix hardcoded name @ https://cs.chromium.org/chromium/src/tools/perf/fetch_benchmark_deps_unittest... to refer it as octane_002.wpr Correct me if i am wrong. BTW, Shall i go ahead remove octane_001.wpr.sha1 which has no purpose anymore?
The CQ bit was checked by sbonda@nvidia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
On 2016/08/05 18:55:37, Srikumar wrote: > Yaa, But i need to fix hardcoded name @ > https://cs.chromium.org/chromium/src/tools/perf/fetch_benchmark_deps_unittest... > to refer it as octane_002.wpr > > Correct me if i am wrong. > > BTW, Shall i go ahead remove octane_001.wpr.sha1 which has no purpose anymore? Yes, that's correct.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sbonda@nvidia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Fix octane test content URL Octane hostname changed to http://chromium.github.io/octane hence fix test URLs BUG=634067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Fix octane test content URL Octane hostname changed to http://chromium.github.io/octane hence fix test URLs BUG=634067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix octane test content URL Octane hostname changed to http://chromium.github.io/octane hence fix test URLs BUG=634067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Fix octane test content URL Octane hostname changed to http://chromium.github.io/octane hence fix test URLs BUG=634067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix octane test content URL Octane hostname changed to http://chromium.github.io/octane hence fix test URLs BUG=634067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Fix octane test content URL Octane hostname changed to http://chromium.github.io/octane hence fix test URLs BUG=634067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/06d7d32a808579e2084c9bba65e217679c500f28 Cr-Commit-Position: refs/heads/master@{#410241} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/06d7d32a808579e2084c9bba65e217679c500f28 Cr-Commit-Position: refs/heads/master@{#410241} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
